Add CommandResponseStatus, CommandResponseProtocolError, and CommandResponseError Callback in IM delegate #5477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhanw-google
force-pushed
the
feature/add_command_request_status_callback
branch
from
8e07b52 to
f2fecad
Compare
erjiaqing
reviewed
Mar 19, 2021
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst,
wehale and
woody-apple
yunhanw-google
force-pushed
the
feature/add_command_request_status_callback
branch
from
f2fecad to
9a8270d
Compare
yunhanw-google
changed the title
yunhanw-google
force-pushed
the
feature/add_command_request_status_callback
branch
from
9a8270d to
d3d1d72
Compare
yunhanw-google
force-pushed
the
feature/add_command_request_status_callback
branch
from
d3d1d72 to
59a3830
Compare
jmartinez-silabs
approved these changes
Mar 22, 2021
yunhanw-google
force-pushed
the
feature/add_command_request_status_callback
branch
from
59a3830 to
9a93230
Compare
yunhanw-google
changed the title
yunhanw-google
force-pushed
the
feature/add_command_request_status_callback
branch
from
9a93230 to
92643c0
Compare
andy31415
approved these changes
Mar 25, 2021
This was referenced Mar 25, 2021
yunhanw-google
force-pushed
the
feature/add_command_request_status_callback
branch
from
92643c0 to
9954780
Compare
yunhanw-google
requested review from
bzbarsky-apple,
vivien-apple and
erjiaqing
yunhanw-google
force-pushed
the
feature/add_command_request_status_callback
branch
from
9954780 to
595adc7
Compare
yunhanw-google
force-pushed
the
feature/add_command_request_status_callback
branch
2 times, most recently
from
1141d2d to
f52b743
Compare
bzbarsky-apple
approved these changes
Mar 30, 2021
yunhanw-google
force-pushed
the
feature/add_command_request_status_callback
branch
from
507c82e to
b48bb68
Compare
…esponseError Callback in IM delegate Problems: Consumer SDK need to get to know the status code when invoke command response has status code inside, and also need to know error when sender fails to process command element and response timeout Summary of Changes: -- After receive status code from invoke command reponse, command sender notify this status code via CommandStatus callback to Consumer SDK. -- When response timeout happens, notify the timeout error to consumer sdk. -- When command element fails to process, notify the protocol error to consuder sdk
yunhanw-google
force-pushed
the
feature/add_command_request_status_callback
branch
from
b48bb68 to
9c48461
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems:
Consumer SDK need to get to know the status code when invoke command
response has status code inside, and also need to know error when sender
fails to process command element and response timeout
Summary of Changes:
-- After receive status code from invoke command reponse, command sender
notify this status code via CommandStatus callback to Consumer SDK.
-- When response timeout happens, notify the timeout error
to consumer sdk.
-- When command element fails to process, notify the protocol error to
consumer sdk.