Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the extra Protocol code typo in AddStatusCode in #5494

Closed
yunhanw-google opened this issue Mar 19, 2021 · 0 comments · Fixed by #5721
Closed

Remove the extra Protocol code typo in AddStatusCode in #5494

yunhanw-google opened this issue Mar 19, 2021 · 0 comments · Fixed by #5721
Assignees
@yunhanw-google

Comments

@yunhanw-google
Copy link
Contributor

Problem

There is extra protocol code in this line,
https://github.com/project-chip/connectedhomeip/blob/master/src/app/Command.cpp#L233

Proposed Solution

Need to remove it
@yunhanw-google yunhanw-google self-assigned this Mar 19, 2021
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Mar 31, 2021
@yunhanw-google
Cleanup status element in IM
474bb51 
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode)
-- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode

fixed project-chip#5494 project-chip#5547
@yunhanw-google yunhanw-google mentioned this issue Mar 31, 2021
Merged
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Mar 31, 2021
@yunhanw-google
Cleanup status element in IM
cf59891 
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode)
-- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode

fixed project-chip#5494 project-chip#5547
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Apr 1, 2021
@yunhanw-google
Cleanup status element in IM
9968a61 
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode)
-- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode.

fixed project-chip#5494 project-chip#5547
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Apr 1, 2021
@yunhanw-google
Cleanup status element in IM
dc59a49 
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode)
-- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode.
-- Remove extra status code insertion in command sender since status
code is only present for command handler.

fixed project-chip#5494 project-chip#5547
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Apr 1, 2021
@yunhanw-google
Cleanup status element in IM
783dc0f 
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode)
-- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode.
-- Remove extra status code insertion in command sender since status
code is only present for command handler.

fixed project-chip#5494 project-chip#5547 project-chip#5756
msandstedt pushed a commit that referenced this issue Apr 2, 2021
@yunhanw-google
Cleanup status element in IM (#5721)
ea6dbf6 
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode)
-- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode.
-- Remove extra status code insertion in command sender since status
code is only present for command handler.

fixed #5494 #5547 #5756
jimlyall-q pushed a commit to jimlyall-q/connectedhomeip that referenced this issue Apr 13, 2021
@yunhanw-google @jimlyall-q
Cleanup status element in IM (project-chip#5721)
9462bee 
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode)
-- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode.
-- Remove extra status code insertion in command sender since status
code is only present for command handler.

fixed project-chip#5494 project-chip#5547 project-chip#5756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yunhanw-google yunhanw-google

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup status element in IM yunhanw-google/connectedhomeip
1 participant
@yunhanw-google