Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra status code insertion in command sender since status code is only present for command handler. #5756

Closed
yunhanw-google opened this issue Apr 1, 2021 · 2 comments
Assignees
Labels
stale Stale issue or PR V1.X

Comments

@yunhanw-google
Copy link
Contributor

Need to remove extra status code insertion in command sender since status
code is only present for command handler.

@yunhanw-google yunhanw-google self-assigned this Apr 1, 2021
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Apr 1, 2021
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode)
-- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode.
-- Remove extra status code insertion in command sender since status
code is only present for command handler.

fixed project-chip#5494 project-chip#5547 project-chip#5756
msandstedt pushed a commit that referenced this issue Apr 2, 2021
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode)
-- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode.
-- Remove extra status code insertion in command sender since status
code is only present for command handler.

fixed #5494 #5547 #5756
jimlyall-q pushed a commit to jimlyall-q/connectedhomeip that referenced this issue Apr 13, 2021
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode)
-- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode.
-- Remove extra status code insertion in command sender since status
code is only present for command handler.

fixed project-chip#5494 project-chip#5547 project-chip#5756
@stale
Copy link

stale bot commented Jul 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jul 25, 2022
@stale
Copy link

stale bot commented Oct 18, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issue or PR V1.X
Projects
None yet
Development

No branches or pull requests

2 participants