Cleanup status element in IM #5721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhanw-google
force-pushed
the
bug/cleanup_status_code
branch
from
474bb51 to
cf59891
Compare
|
Needs restyle |
msandstedt
approved these changes
Apr 1, 2021
yunhanw-google
force-pushed
the
bug/cleanup_status_code
branch
from
cf59891 to
9968a61
Compare
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda and
mspang
andy31415
approved these changes
Apr 1, 2021
yunhanw-google
force-pushed
the
bug/cleanup_status_code
branch
from
9968a61 to
dc59a49
Compare
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode) -- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode. -- Remove extra status code insertion in command sender since status code is only present for command handler. fixed project-chip#5494 project-chip#5547 project-chip#5756
yunhanw-google
force-pushed
the
bug/cleanup_status_code
branch
from
dc59a49 to
783dc0f
Compare
LuDuda
approved these changes
Apr 2, 2021
jimlyall-q
pushed a commit
to jimlyall-q/connectedhomeip
that referenced
this pull request
Apr 13, 2021
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode) -- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode. -- Remove extra status code insertion in command sender since status code is only present for command handler. fixed project-chip#5494 project-chip#5547 project-chip#5756
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
-- Remove extra protocolcode typo in EncodeStatusElement(aGeneralCode, aProtocolId.ToFullyQualifiedSpecForm(), aProtocolCode, aProtocolCode)
-- Replace aGeneralCode with chip::Protocols::SecureChannel::GeneralStatusCode.
-- Remove extra status code insertion in command sender since status
code is only present for command handler.
fixed #5494 #5547 #5756