chore: add localnet_config option to disable hot-reloading #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
added
the
tooling
red-0ne
approved these changes
Dec 2, 2024
bryanchriswhite
added a commit
that referenced
this pull request
Dec 2, 2024
…lier_staking_fee * pokt/main: chore: add localnet_config option to disable hot-reloading (#979) [Code Health] fix: tokenomics module gRPC return errors (#963) [Code Health] fix: supplier module gRPC return errors (#962) [Supplier] feat: add `staking_fee` param to supplier module (#944) [Code Health] fix: application module gRPC status error returns (#954) [Code Health] fix: shared module gRPC return errors (#961) [Code Health] fix: session module gRPC status return errors (#960) [Code Health] fix: service module gRPC status error returns (#959) [Code Health] fix: proof module gRPC status error returns (#956) [Code Health] fix: gateway module gRPC status error returns (#955)
bryanchriswhite
added a commit
that referenced
this pull request
Dec 2, 2024
…/params/global_inflation_per_claim * todo_beta/refactor/supplier_staking_fee: (21 commits) chore: add localnet_config option to disable hot-reloading (#979) [Code Health] fix: tokenomics module gRPC return errors (#963) [Code Health] fix: supplier module gRPC return errors (#962) [Supplier] feat: add `staking_fee` param to supplier module (#944) [Code Health] fix: application module gRPC status error returns (#954) [Code Health] fix: shared module gRPC return errors (#961) [Code Health] fix: session module gRPC status return errors (#960) [Code Health] fix: service module gRPC status error returns (#959) [Code Health] fix: proof module gRPC status error returns (#956) [Code Health] fix: gateway module gRPC status error returns (#955) [Tokenomics] feat: add `target_num_relays` param to service module (#930) chore: review feedback improvements chore: review feedback improvements [Docs/Tools] Validator: support multiple networks + cheat sheet (#941) [Docs] Upgrade list (#928) [Service] refactor: `TargetNumRelays` var usage to param usage (#943) [Docs] Beta TestNet - Service Cheatsheet (#965) Commit outdated proto files [Docs] adding params - fix gRPC status error code (#958) [Docs] Update links to RPC & explorers (#950) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a top-level
hot-reloadingboolean field tolocalnet_config.yamlin order to support easier disabling hot-reload.Issue
There are times where hot-reloading is not desireable. In these instances, in the absence of such a config option, it takes 6 button clicks in the UI to accomplish the same result.
Type of change
Select one or more from the following:
consensus-breakinglabel if so. See [Infra] Automatically add theconsensus-breakinglabel #791 for detailsTesting
make docusaurus_start; only needed if you make doc changesmake go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR.Sanity Checklist