[Tokenomics] feat: add target_num_relays param to service module
#930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
added
service
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 930) |
github-actions
bot
added
devnet
push-image
bryanchriswhite
changed the base branch from
issues/881/refactor/settlement
to
main
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
bryanchriswhite
force-pushed
the
todo_beta/params/target_num_relays
branch
from
037c75c
to
03fe323
Compare
bryanchriswhite
commented
Nov 21, 2024
red-0ne
approved these changes
Nov 27, 2024
## Summary Replace usage of `servicekeeper.TargetNumRelays` with the new param and delete it. ## Issue - `TODO_BETA` ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [x] **Unit Tests**: `make go_develop_and_test` - [ ] **LocalNet E2E Tests**: `make test_e2e` - [x] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [ ] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable
Co-authored-by: red-0ne <[email protected]>
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 930) |
…_num_relays * pokt/main: [Docs/Tools] Validator: support multiple networks + cheat sheet (#941) [Docs] Upgrade list (#928) [Docs] Beta TestNet - Service Cheatsheet (#965) Commit outdated proto files [Docs] adding params - fix gRPC status error code (#958) [Docs] Update links to RPC & explorers (#950) [Docs] Update documentation on installing the `poktrolld` CLI (#949)
bryanchriswhite
added a commit
that referenced
this pull request
Dec 2, 2024
* pokt/main: [Code Health] fix: application module gRPC status error returns (#954) [Code Health] fix: shared module gRPC return errors (#961) [Code Health] fix: session module gRPC status return errors (#960) [Code Health] fix: service module gRPC status error returns (#959) [Code Health] fix: proof module gRPC status error returns (#956) [Code Health] fix: gateway module gRPC status error returns (#955) [Tokenomics] feat: add `target_num_relays` param to service module (#930)
bryanchriswhite
added a commit
that referenced
this pull request
Dec 2, 2024
…/params/global_inflation_per_claim * todo_beta/refactor/supplier_staking_fee: (21 commits) chore: add localnet_config option to disable hot-reloading (#979) [Code Health] fix: tokenomics module gRPC return errors (#963) [Code Health] fix: supplier module gRPC return errors (#962) [Supplier] feat: add `staking_fee` param to supplier module (#944) [Code Health] fix: application module gRPC status error returns (#954) [Code Health] fix: shared module gRPC return errors (#961) [Code Health] fix: session module gRPC status return errors (#960) [Code Health] fix: service module gRPC status error returns (#959) [Code Health] fix: proof module gRPC status error returns (#956) [Code Health] fix: gateway module gRPC status error returns (#955) [Tokenomics] feat: add `target_num_relays` param to service module (#930) chore: review feedback improvements chore: review feedback improvements [Docs/Tools] Validator: support multiple networks + cheat sheet (#941) [Docs] Upgrade list (#928) [Service] refactor: `TargetNumRelays` var usage to param usage (#943) [Docs] Beta TestNet - Service Cheatsheet (#965) Commit outdated proto files [Docs] adding params - fix gRPC status error code (#958) [Docs] Update links to RPC & explorers (#950) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
target_num_relayparam to the tokenomics module.Issue
TODO_BETAType of change
Select one or more from the following:
consensus-breakinglabel if so. See [Infra] Automatically add theconsensus-breakinglabel #791 for detailsTesting
make docusaurus_start; only needed if you make doc changesmake go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR.Sanity Checklist