Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Health] fix: service module gRPC status error returns #959

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Nov 25, 2024

Summary

Ensure all service module message and query handlers return gRPC status errors.

Issue

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added on-chain On-chain business logic code health Cleans up some code labels Nov 25, 2024
@bryanchriswhite bryanchriswhite self-assigned this Nov 25, 2024
Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 959)
Grafana network dashboard for devnet-issue-959

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Nov 25, 2024
@bryanchriswhite bryanchriswhite added service Anything related to general-purpose RPC service support and removed push-image CI related - pushes images to ghcr.io devnet labels Nov 25, 2024
@bryanchriswhite bryanchriswhite added push-image CI related - pushes images to ghcr.io devnet devnet-test-e2e labels Nov 25, 2024
Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 959)
Grafana network dashboard for devnet-issue-959

Copy link

The image is going to be pushed after the next commit.

You can use make trigger_ci to push an empty commit.

If you also want to run E2E tests, please add devnet-test-e2e label.

@bryanchriswhite bryanchriswhite marked this pull request as ready for review November 25, 2024 15:01
@bryanchriswhite bryanchriswhite added consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. and removed push-image CI related - pushes images to ghcr.io devnet labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Cleans up some code consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. on-chain On-chain business logic service Anything related to general-purpose RPC service support
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

2 participants