Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs/Tools] Validator: support multiple networks + cheat sheet #941

Merged
merged 18 commits into from
Nov 27, 2024

Conversation

okdas
Copy link
Member

@okdas okdas commented Nov 21, 2024

Summary

Allows to support multiple networks in the installation script.

Issue

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@okdas okdas added the code health Cleans up some code label Nov 21, 2024
@okdas okdas added this to the Shannon Beta TestNet Launch milestone Nov 21, 2024
@okdas okdas self-assigned this Nov 21, 2024
@okdas okdas marked this pull request as ready for review November 21, 2024 21:07
tools/installer/full-node.sh Outdated Show resolved Hide resolved
tools/installer/full-node.sh Show resolved Hide resolved
tools/installer/full-node.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@bryanchriswhite bryanchriswhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice bashing sir! 😎 💥 Super easy to read. 🤩

tools/installer/full-node.sh Outdated Show resolved Hide resolved
tools/installer/full-node.sh Outdated Show resolved Hide resolved
tools/installer/full-node.sh Outdated Show resolved Hide resolved
tools/installer/full-node.sh Outdated Show resolved Hide resolved
tools/installer/full-node.sh Outdated Show resolved Hide resolved
tools/installer/full-node.sh Show resolved Hide resolved
tools/installer/full-node.sh Outdated Show resolved Hide resolved
tools/installer/full-node.sh Show resolved Hide resolved
tools/installer/full-node.sh Outdated Show resolved Hide resolved
@okdas okdas changed the title [Install script] Support multiple networks [Docs] Install validator on different networks Nov 26, 2024
@okdas okdas changed the title [Docs] Install validator on different networks [Docs/Tools] Validator: support multiple networks + cheat sheet Nov 26, 2024
@okdas okdas requested a review from Olshansk November 26, 2024 02:31
@Olshansk Olshansk added the documentation Improvements or additions to documentation label Nov 26, 2024
@okdas okdas merged commit 76d131c into main Nov 27, 2024
13 of 14 checks passed
bryanchriswhite added a commit that referenced this pull request Dec 2, 2024
…_num_relays

* pokt/main:
  [Docs/Tools] Validator: support multiple networks + cheat sheet (#941)
  [Docs] Upgrade list (#928)
  [Docs] Beta TestNet - Service Cheatsheet (#965)
  Commit outdated proto files
  [Docs] adding params - fix gRPC status error code (#958)
  [Docs] Update links to RPC & explorers (#950)
  [Docs] Update documentation on installing the `poktrolld` CLI (#949)
bryanchriswhite added a commit that referenced this pull request Dec 2, 2024
…/params/global_inflation_per_claim

* todo_beta/refactor/supplier_staking_fee: (21 commits)
  chore: add localnet_config option to disable hot-reloading (#979)
  [Code Health] fix: tokenomics module gRPC return errors (#963)
  [Code Health] fix: supplier module gRPC return errors (#962)
  [Supplier] feat: add `staking_fee` param to supplier module (#944)
  [Code Health] fix: application module gRPC status error returns (#954)
  [Code Health] fix: shared module gRPC return errors (#961)
  [Code Health] fix: session module gRPC status return errors (#960)
  [Code Health] fix: service module gRPC status error returns (#959)
  [Code Health] fix: proof module gRPC status error returns (#956)
  [Code Health] fix: gateway module gRPC status error returns (#955)
  [Tokenomics] feat: add `target_num_relays` param to service module (#930)
  chore: review feedback improvements
  chore: review feedback improvements
  [Docs/Tools] Validator: support multiple networks + cheat sheet (#941)
  [Docs] Upgrade list (#928)
  [Service] refactor: `TargetNumRelays` var usage to param usage (#943)
  [Docs] Beta TestNet - Service Cheatsheet (#965)
  Commit outdated proto files
  [Docs] adding params - fix gRPC status error code (#958)
  [Docs] Update links to RPC & explorers (#950)
  ...
@Olshansk
Copy link
Member

Olshansk commented Dec 4, 2024

Posted my review as a followup PR: #981

Olshansk added a commit that referenced this pull request Dec 5, 2024
## Summary

- Improvements to the Full Node walkthrough + cheatsheet
- A handful of other miscleanious changes to make the docs more
"holistic"
- Prep for the validator cheatsheets
- 
## Issue

- Followup to #941

## Type of change

Select one or more from the following:

- [ ] New feature, functionality or library
- [ ] Consensus breaking; add the `consensus-breaking` label if so. See
#791 for details
- [ ] Bug fix
- [ ] Code health or cleanup
- [x] Documentation
- [ ] Other (specify)

---------

Co-authored-by: Redouane Lakrache <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Cleans up some code documentation Improvements or additions to documentation
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants