Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] adding params - fix gRPC status error code #958

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

bryanchriswhite
Copy link
Contributor

Summary

func (k msgServer) UpdateParam(ctx context.Context, msg *examplemodtypes.MsgUpdateParam) (*examplemodtypes.MsgUpdateParamResponse, error) {
	// ...
	if k.GetAuthority() != msg.Authority {
		return nil, status.Error(
-			codes.InvalidArgument,
+			codes.PermissionDenied,
			examplemodtypes.ErrExamplemodInvalidSigner.Wrapf(
				"invalid authority; expected %s, got %s",
				k.GetAuthority(), msg.Authority,
			).Error(),
		)
	}
	// ...
}

Issue

  • N/A

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added documentation Improvements or additions to documentation governance Governance related changes on-chain On-chain business logic labels Nov 25, 2024
@bryanchriswhite bryanchriswhite self-assigned this Nov 25, 2024
@bryanchriswhite bryanchriswhite changed the title [Docs] fix gRPC status error code [Docs] adding params - fix gRPC status error code Nov 25, 2024
@bryanchriswhite bryanchriswhite marked this pull request as ready for review November 25, 2024 16:40
@bryanchriswhite bryanchriswhite merged commit 4ad2c91 into main Nov 25, 2024
17 checks passed
@bryanchriswhite bryanchriswhite deleted the docs/adding_params branch November 25, 2024 19:41
bryanchriswhite added a commit that referenced this pull request Dec 2, 2024
…_num_relays

* pokt/main:
  [Docs/Tools] Validator: support multiple networks + cheat sheet (#941)
  [Docs] Upgrade list (#928)
  [Docs] Beta TestNet - Service Cheatsheet (#965)
  Commit outdated proto files
  [Docs] adding params - fix gRPC status error code (#958)
  [Docs] Update links to RPC & explorers (#950)
  [Docs] Update documentation on installing the `poktrolld` CLI (#949)
bryanchriswhite added a commit that referenced this pull request Dec 2, 2024
…/params/global_inflation_per_claim

* todo_beta/refactor/supplier_staking_fee: (21 commits)
  chore: add localnet_config option to disable hot-reloading (#979)
  [Code Health] fix: tokenomics module gRPC return errors (#963)
  [Code Health] fix: supplier module gRPC return errors (#962)
  [Supplier] feat: add `staking_fee` param to supplier module (#944)
  [Code Health] fix: application module gRPC status error returns (#954)
  [Code Health] fix: shared module gRPC return errors (#961)
  [Code Health] fix: session module gRPC status return errors (#960)
  [Code Health] fix: service module gRPC status error returns (#959)
  [Code Health] fix: proof module gRPC status error returns (#956)
  [Code Health] fix: gateway module gRPC status error returns (#955)
  [Tokenomics] feat: add `target_num_relays` param to service module (#930)
  chore: review feedback improvements
  chore: review feedback improvements
  [Docs/Tools] Validator: support multiple networks + cheat sheet (#941)
  [Docs] Upgrade list (#928)
  [Service] refactor: `TargetNumRelays` var usage to param usage (#943)
  [Docs] Beta TestNet - Service Cheatsheet (#965)
  Commit outdated proto files
  [Docs] adding params - fix gRPC status error code (#958)
  [Docs] Update links to RPC & explorers (#950)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation governance Governance related changes on-chain On-chain business logic
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants