Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add public start, stop, and step attributes to RangeIndex #25720

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

jschendel
Copy link
Member

Comments:

  • Was originally going to add the tests for this to test_constructor but decided to create a new test instead. I parametrized test_constructor to clean it up before deciding to create a separate test and kept those changes in the PR.
  • Copied the start/stop/step docstrings from the Python docs for range with a small rewording to fit it on one line

@jschendel jschendel added API Design Index Related to the Index class or subclasses labels Mar 14, 2019
@jschendel jschendel added this to the 0.25.0 milestone Mar 14, 2019
@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #25720 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25720      +/-   ##
==========================================
- Coverage   91.24%   91.24%   -0.01%     
==========================================
  Files         172      172              
  Lines       52967    52973       +6     
==========================================
+ Hits        48332    48337       +5     
- Misses       4635     4636       +1
Flag Coverage Δ
#multiple 89.82% <100%> (ø) ⬆️
#single 41.75% <50%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/range.py 97.41% <100%> (+0.04%) ⬆️
pandas/util/testing.py 88.98% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1017382...70bd4d6. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #25720 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25720      +/-   ##
==========================================
- Coverage   91.24%   91.24%   -0.01%     
==========================================
  Files         172      172              
  Lines       52967    52973       +6     
==========================================
+ Hits        48332    48337       +5     
- Misses       4635     4636       +1
Flag Coverage Δ
#multiple 89.82% <100%> (ø) ⬆️
#single 41.75% <50%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/range.py 97.41% <100%> (+0.04%) ⬆️
pandas/util/testing.py 88.98% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1017382...70bd4d6. Read the comment docs.

@jreback jreback merged commit 873e22e into pandas-dev:master Mar 14, 2019
@jreback
Copy link
Contributor

jreback commented Mar 14, 2019

thanks @jschendel very nice

sighingnow added a commit to sighingnow/pandas that referenced this pull request Mar 14, 2019
* master: (22 commits)
  Fixturize tests/frame/test_operators.py (pandas-dev#25641)
  Update ValueError message in corr (pandas-dev#25729)
  DOC: fix some grammar and inconsistency issues in the User Guide (pandas-dev#25728)
  ENH: Add public start, stop, and step attributes to RangeIndex (pandas-dev#25720)
  Make Rolling.apply documentation clearer (pandas-dev#25712)
  pandas-dev#25707 - Fixed flakiness in stata write test (pandas-dev#25714)
  Json normalize nan support (pandas-dev#25619)
  TST: resolve issues with test_constructor_dtype_datetime64 (pandas-dev#24868)
  DEPR: Deprecate box kwarg for to_timedelta and to_datetime (pandas-dev#24486)
  BUG: Preserve name in DatetimeIndex.snap (pandas-dev#25585)
  Fix concat not respecting order of OrderedDict (pandas-dev#25224)
  CLN: remove pandas.core.categorical (pandas-dev#25655)
  TST/CLN: Remove more Panel tests (pandas-dev#25675)
  Pinned pycodestyle (pandas-dev#25701)
  DOC: update date of 0.24.2 release notes (pandas-dev#25699)
  BUG: Fix error in replace with strings that are large numbers (pandas-dev#25616) (pandas-dev#25644)
  BUG: fix usage of na_sentinel with sort=True in factorize() (pandas-dev#25592)
  BUG: Fix to_string output when using header (pandas-dev#16718) (pandas-dev#25602)
  CLN: Remove unused test code (pandas-dev#25670)
  CLN: remove Panel from concat error message (pandas-dev#25676)
  ...

# Conflicts:
#	doc/source/whatsnew/v0.25.0.rst
@jschendel jschendel deleted the ri-public-attrs branch March 14, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design Index Related to the Index class or subclasses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make public start, stop and step attributes for RangeIndex
2 participants