CLN: Remove unused test code #25670
Merged
CLN: Remove unused test code #25670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
commented
Mar 11, 2019
| @@ -31,7 +31,6 @@ | |||
| assert_series_equal, makeCustomDataframe as mkdf, randbool) | |||
|
|
|||
| _series_frame_incompatible = _bool_ops_syms | |||
There was a problem hiding this comment.
_series_frame_incompatible can also be removed. AFK for a short while. will remove.
WillAyd
reviewed
Mar 11, 2019
| @@ -168,7 +167,15 @@ def test_complex_cmp_ops(self): | |||
| for lhs, cmp1, rhs, binop, cmp2 in product(self.lhses, cmp_ops, | |||
There was a problem hiding this comment.
Does it make sense to parametrize this?
WillAyd
added
Testing
|
I did start but got into a bit of a mess needs fixture isation first
…On Mon, 11 Mar 2019, 17:52 William Ayd, ***@***.***> wrote:
***@***.**** commented on this pull request.
Great thanks as always for the PR. One comment on quick glance - will deep
dive into review later
------------------------------
In pandas/tests/computation/test_eval.py
<#25670 (comment)>:
> @@ -168,7 +167,15 @@ def test_complex_cmp_ops(self):
for lhs, cmp1, rhs, binop, cmp2 in product(self.lhses, cmp_ops,
Does it make sense to parametrize this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#25670 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMjKXZUpJfRRy4GQGmsHTxwNyUH_sKvLks5vVpfIgaJpZM4bpLXM>
.
|
Codecov Report
@@ Coverage Diff @@
## master #25670 +/- ##
==========================================
+ Coverage 91.29% 91.29% +<.01%
==========================================
Files 173 173
Lines 52961 52961
==========================================
+ Hits 48349 48350 +1
+ Misses 4612 4611 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25670 +/- ##
=======================================
Coverage 91.29% 91.29%
=======================================
Files 173 173
Lines 52961 52961
=======================================
Hits 48349 48349
Misses 4612 4612
Continue to review full report at Codecov.
|
|
thanks @simonjayhawkins |
sighingnow
added a commit
to sighingnow/pandas
that referenced
this pull request
Mar 14, 2019
* master: (22 commits) Fixturize tests/frame/test_operators.py (pandas-dev#25641) Update ValueError message in corr (pandas-dev#25729) DOC: fix some grammar and inconsistency issues in the User Guide (pandas-dev#25728) ENH: Add public start, stop, and step attributes to RangeIndex (pandas-dev#25720) Make Rolling.apply documentation clearer (pandas-dev#25712) pandas-dev#25707 - Fixed flakiness in stata write test (pandas-dev#25714) Json normalize nan support (pandas-dev#25619) TST: resolve issues with test_constructor_dtype_datetime64 (pandas-dev#24868) DEPR: Deprecate box kwarg for to_timedelta and to_datetime (pandas-dev#24486) BUG: Preserve name in DatetimeIndex.snap (pandas-dev#25585) Fix concat not respecting order of OrderedDict (pandas-dev#25224) CLN: remove pandas.core.categorical (pandas-dev#25655) TST/CLN: Remove more Panel tests (pandas-dev#25675) Pinned pycodestyle (pandas-dev#25701) DOC: update date of 0.24.2 release notes (pandas-dev#25699) BUG: Fix error in replace with strings that are large numbers (pandas-dev#25616) (pandas-dev#25644) BUG: fix usage of na_sentinel with sort=True in factorize() (pandas-dev#25592) BUG: Fix to_string output when using header (pandas-dev#16718) (pandas-dev#25602) CLN: Remove unused test code (pandas-dev#25670) CLN: remove Panel from concat error message (pandas-dev#25676) ... # Conflicts: # doc/source/whatsnew/v0.25.0.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @WillAyd same code as cleaned in #25647
intention originally to just deal with the commented out instance of
pytest.raisesfor #24332 but may have gone too far!