Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Preserve name in DatetimeIndex.snap #25585

Merged
merged 4 commits into from
Mar 13, 2019

Conversation

sighingnow
Copy link
Contributor

Use self.name to construct the result of DatetimeIndex.snap, fix #25575.

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #25585 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25585      +/-   ##
==========================================
+ Coverage   91.26%   91.26%   +<.01%     
==========================================
  Files         173      173              
  Lines       52966    52966              
==========================================
+ Hits        48337    48338       +1     
+ Misses       4629     4628       -1
Flag Coverage Δ
#multiple 89.83% <100%> (ø) ⬆️
#single 41.71% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/datetimes.py 96.41% <100%> (ø) ⬆️
pandas/util/testing.py 87.66% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74a9ae3...591f47f. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #25585 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25585      +/-   ##
==========================================
- Coverage   91.26%   91.25%   -0.01%     
==========================================
  Files         173      172       -1     
  Lines       52966    52963       -3     
==========================================
- Hits        48337    48330       -7     
- Misses       4629     4633       +4
Flag Coverage Δ
#multiple 89.82% <100%> (-0.02%) ⬇️
#single 41.73% <0%> (+0.02%) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/datetimes.py 96.41% <100%> (ø) ⬆️
pandas/core/panel.py 35.72% <0%> (-2.85%) ⬇️
pandas/core/generic.py 93.51% <0%> (-0.15%) ⬇️
pandas/plotting/_core.py 83.53% <0%> (-0.05%) ⬇️
pandas/core/config.py 87% <0%> (-0.05%) ⬇️
pandas/io/formats/format.py 97.99% <0%> (ø) ⬆️
pandas/core/arrays/sparse.py 92.17% <0%> (ø) ⬆️
pandas/core/groupby/base.py 91.83% <0%> (ø) ⬆️
pandas/core/base.py 97.76% <0%> (ø) ⬆️
pandas/core/frame.py 96.79% <0%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74a9ae3...b169fa8. Read the comment docs.

@gfyoung gfyoung added Bug Datetime Datetime data dtype labels Mar 7, 2019
pandas/tests/series/indexing/test_datetime.py Outdated Show resolved Hide resolved
doc/source/whatsnew/v0.24.2.rst Outdated Show resolved Hide resolved
@jreback jreback added this to the 0.25.0 milestone Mar 13, 2019
@jreback jreback merged commit 203481f into pandas-dev:master Mar 13, 2019
@jreback
Copy link
Contributor

jreback commented Mar 13, 2019

thanks!

@sighingnow sighingnow deleted the fix-25575 branch March 14, 2019 02:26
sighingnow added a commit to sighingnow/pandas that referenced this pull request Mar 14, 2019
* master: (22 commits)
  Fixturize tests/frame/test_operators.py (pandas-dev#25641)
  Update ValueError message in corr (pandas-dev#25729)
  DOC: fix some grammar and inconsistency issues in the User Guide (pandas-dev#25728)
  ENH: Add public start, stop, and step attributes to RangeIndex (pandas-dev#25720)
  Make Rolling.apply documentation clearer (pandas-dev#25712)
  pandas-dev#25707 - Fixed flakiness in stata write test (pandas-dev#25714)
  Json normalize nan support (pandas-dev#25619)
  TST: resolve issues with test_constructor_dtype_datetime64 (pandas-dev#24868)
  DEPR: Deprecate box kwarg for to_timedelta and to_datetime (pandas-dev#24486)
  BUG: Preserve name in DatetimeIndex.snap (pandas-dev#25585)
  Fix concat not respecting order of OrderedDict (pandas-dev#25224)
  CLN: remove pandas.core.categorical (pandas-dev#25655)
  TST/CLN: Remove more Panel tests (pandas-dev#25675)
  Pinned pycodestyle (pandas-dev#25701)
  DOC: update date of 0.24.2 release notes (pandas-dev#25699)
  BUG: Fix error in replace with strings that are large numbers (pandas-dev#25616) (pandas-dev#25644)
  BUG: fix usage of na_sentinel with sort=True in factorize() (pandas-dev#25592)
  BUG: Fix to_string output when using header (pandas-dev#16718) (pandas-dev#25602)
  CLN: Remove unused test code (pandas-dev#25670)
  CLN: remove Panel from concat error message (pandas-dev#25676)
  ...

# Conflicts:
#	doc/source/whatsnew/v0.25.0.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Datetime Datetime data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snap drops name from datetimeindex
4 participants