Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix to_string output when using header keyword arg (#16718) #25602

Merged

Conversation

tomneep
Copy link
Contributor

@tomneep tomneep commented Mar 8, 2019

Also affects to_latex midrule position

Fixes the 4th example in the above issue.

@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #25602 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25602   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files         173      173           
  Lines       52968    52968           
=======================================
  Hits        48339    48339           
  Misses       4629     4629
Flag Coverage Δ
#multiple 89.83% <100%> (ø) ⬆️
#single 41.71% <33.33%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/formats/format.py 97.99% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c159d2...bc37b34. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #25602 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25602      +/-   ##
==========================================
- Coverage   91.29%   91.29%   -0.01%     
==========================================
  Files         173      173              
  Lines       52961    52961              
==========================================
- Hits        48350    48349       -1     
- Misses       4611     4612       +1
Flag Coverage Δ
#multiple 89.86% <100%> (ø) ⬆️
#single 41.73% <33.33%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/formats/format.py 97.99% <100%> (ø) ⬆️
pandas/util/testing.py 88.98% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9185af2...58c9346. Read the comment docs.

@jreback jreback added IO LaTeX to_latex Output-Formatting __repr__ of pandas objects, to_string labels Mar 9, 2019
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mentioned this affects the latex output, can you add a test case for the same. pls add a note in 0.25.0 as well.

@tomneep tomneep force-pushed the to_latex_multiindex_midrule branch from bc37b34 to c81f1a9 Compare March 12, 2019 08:30
Also affects to_latex midrule position
Tests added for both to_string and to_latex
Whatsnew added for v0.25.0
@tomneep tomneep force-pushed the to_latex_multiindex_midrule branch from c81f1a9 to 58c9346 Compare March 12, 2019 08:35
@tomneep
Copy link
Contributor Author

tomneep commented Mar 12, 2019

I've added a test for to_latex and a whatsnew entry. Let me know if you want me to change anything else.

@TomAugspurger TomAugspurger merged commit 5c341dc into pandas-dev:master Mar 12, 2019
@TomAugspurger
Copy link
Contributor

Thanks @tomneep!

@TomAugspurger TomAugspurger added this to the 0.25.0 milestone Mar 12, 2019
@tomneep tomneep deleted the to_latex_multiindex_midrule branch March 14, 2019 09:18
sighingnow added a commit to sighingnow/pandas that referenced this pull request Mar 14, 2019
* master: (22 commits)
  Fixturize tests/frame/test_operators.py (pandas-dev#25641)
  Update ValueError message in corr (pandas-dev#25729)
  DOC: fix some grammar and inconsistency issues in the User Guide (pandas-dev#25728)
  ENH: Add public start, stop, and step attributes to RangeIndex (pandas-dev#25720)
  Make Rolling.apply documentation clearer (pandas-dev#25712)
  pandas-dev#25707 - Fixed flakiness in stata write test (pandas-dev#25714)
  Json normalize nan support (pandas-dev#25619)
  TST: resolve issues with test_constructor_dtype_datetime64 (pandas-dev#24868)
  DEPR: Deprecate box kwarg for to_timedelta and to_datetime (pandas-dev#24486)
  BUG: Preserve name in DatetimeIndex.snap (pandas-dev#25585)
  Fix concat not respecting order of OrderedDict (pandas-dev#25224)
  CLN: remove pandas.core.categorical (pandas-dev#25655)
  TST/CLN: Remove more Panel tests (pandas-dev#25675)
  Pinned pycodestyle (pandas-dev#25701)
  DOC: update date of 0.24.2 release notes (pandas-dev#25699)
  BUG: Fix error in replace with strings that are large numbers (pandas-dev#25616) (pandas-dev#25644)
  BUG: fix usage of na_sentinel with sort=True in factorize() (pandas-dev#25592)
  BUG: Fix to_string output when using header (pandas-dev#16718) (pandas-dev#25602)
  CLN: Remove unused test code (pandas-dev#25670)
  CLN: remove Panel from concat error message (pandas-dev#25676)
  ...

# Conflicts:
#	doc/source/whatsnew/v0.25.0.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO LaTeX to_latex Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: to_latex: Problems with MultiIndex / Mixed Index
3 participants