Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Rolling.apply documentation clearer #25712

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Make Rolling.apply documentation clearer #25712

merged 1 commit into from
Mar 14, 2019

Conversation

bharatr21
Copy link
Contributor

Fix #25656 by making Rolling.apply documentation clearer (hope this is what @js3711 intended)

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #25712 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25712   +/-   ##
=======================================
  Coverage   91.24%   91.24%           
=======================================
  Files         172      172           
  Lines       52967    52967           
=======================================
  Hits        48332    48332           
  Misses       4635     4635
Flag Coverage Δ
#multiple 89.82% <ø> (ø) ⬆️
#single 41.74% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/window.py 96.4% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ae24b...d9439f6. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #25712 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25712   +/-   ##
=======================================
  Coverage   91.24%   91.24%           
=======================================
  Files         172      172           
  Lines       52967    52967           
=======================================
  Hits        48332    48332           
  Misses       4635     4635
Flag Coverage Δ
#multiple 89.82% <ø> (ø) ⬆️
#single 41.74% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/window.py 96.4% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ae24b...d9439f6. Read the comment docs.

@WillAyd WillAyd added the Docs label Mar 14, 2019
@WillAyd WillAyd added this to the 0.25.0 milestone Mar 14, 2019
@WillAyd WillAyd merged commit 79205ea into pandas-dev:master Mar 14, 2019
@WillAyd
Copy link
Member

WillAyd commented Mar 14, 2019

Thanks @Bharat123rox

sighingnow added a commit to sighingnow/pandas that referenced this pull request Mar 14, 2019
* master: (22 commits)
  Fixturize tests/frame/test_operators.py (pandas-dev#25641)
  Update ValueError message in corr (pandas-dev#25729)
  DOC: fix some grammar and inconsistency issues in the User Guide (pandas-dev#25728)
  ENH: Add public start, stop, and step attributes to RangeIndex (pandas-dev#25720)
  Make Rolling.apply documentation clearer (pandas-dev#25712)
  pandas-dev#25707 - Fixed flakiness in stata write test (pandas-dev#25714)
  Json normalize nan support (pandas-dev#25619)
  TST: resolve issues with test_constructor_dtype_datetime64 (pandas-dev#24868)
  DEPR: Deprecate box kwarg for to_timedelta and to_datetime (pandas-dev#24486)
  BUG: Preserve name in DatetimeIndex.snap (pandas-dev#25585)
  Fix concat not respecting order of OrderedDict (pandas-dev#25224)
  CLN: remove pandas.core.categorical (pandas-dev#25655)
  TST/CLN: Remove more Panel tests (pandas-dev#25675)
  Pinned pycodestyle (pandas-dev#25701)
  DOC: update date of 0.24.2 release notes (pandas-dev#25699)
  BUG: Fix error in replace with strings that are large numbers (pandas-dev#25616) (pandas-dev#25644)
  BUG: fix usage of na_sentinel with sort=True in factorize() (pandas-dev#25592)
  BUG: Fix to_string output when using header (pandas-dev#16718) (pandas-dev#25602)
  CLN: Remove unused test code (pandas-dev#25670)
  CLN: remove Panel from concat error message (pandas-dev#25676)
  ...

# Conflicts:
#	doc/source/whatsnew/v0.25.0.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rolling.apply documentation not clear
2 participants