Sharing NG

[JammingBen]

Sharing NG is the next gen sharing API in oCIS that deprecates the old OCS API. The purpose of this issue is to keep track of all the things that need to be done in Web to fully make the switch to the new API.

Basic functionality

• Implement sharing NG for listing shares (refactor: use sharing NG for share listings #10392)
• Implement sharing NG for sidebar share loading & CRUD (refactor: implement sharing NG crud operations #10433)
• Make proper use of permissions ([Web & ocis] Make proper use of share permissions instead of roles #10770)
• Denies (currently blocked by the server)

Bugs

• Password modal is missing when passwords are enforced for links and an internal link is being updated to the type edit. (fix: missing password modal on link type change #10690)
• Banned password error message isn't captalized and therefore can't be translated (fix: capitalization of banned password error message #10685)
• The role display names and descriptions are not as they were before (server issue)
• Some role display names and descriptions are not being translated yet, they need to be added to the additional translations for Transifex to pick them up. (fix: missing translations for share roles #10695)
• Share date is missing ([Sharing NG] Use share date coming from the API #10778)
• rework sharing indicators since there is no more resharing (fix: share indicators for incoming shares #10759)

Hacks to be removed when server is ready

• Tokeninfo for public links (see issue [Sharing NG] Replace tokeninfo endpoint #10689)
• hidden property ([Sharing NG] Use graph endpoints for hidden state of shares #10768)
• Suggested roles (refactor: remove available shares roles hack  #10774)
• Space root endpoint for space roots (refactor: make use of permission root endpoints for spaces #10745)
• Role icon map ([Sharing NG] Remove share role icon map #10777)

Tests

• Add unit tests (test: add component unit tests for sharing NG implementation #10704 & test: add unit tests for share helper functions #10710)
• Adjust e2e and acceptance test role selectors and remove human readable id mappings (refactor: remove hacks for share role tests #10684)

Checks

• Check that federated sharing (OCM) still works (currently blocked by [Sharing NG] add OCM Shares to SharingNG ocis#8564)
• Check that fullShareOwnerPaths still work as expected
• Check if we still need to distinguish between space and non-space share types. Or more radical: can we remove the concept of share types as a whole? (refactor: remove space share types #10701)
• Check that the capabilities for passwords are respected correctly
• Check if https://github.com/owncloud/web/blob/master/packages/web-app-files/src/components/SideBar/Shares/SharesPanel.vue#L50 can be removed (refactor: remove shares panel separation for details query #10696)
• Check if space member loading and setting can be simplified (refactor: space member loading #10699)

Clean up

• Remove aggregateResourceShares (refactor: remove aggregateResourceShares and share prop on share resources #10426)
• Remove ShareStatus and status property from the ShareResource interface (refactor: remove share status in favour of syncEnabled #10421)
• Remove share property from the ShareResource interface (refactor: remove aggregateResourceShares and share prop on share resources #10426)
• Remove re-sharing logic
• Remove SharePermission and SharePermissions (refactor: remove share permission abstract classes #10694)
• Remove SharePermissionBit ([Sharing NG] Remove SharePermissionBit #10772 - blocked by [Sharing NG] Replace dav property public-link-permission with type ocis#8740 and [Sharing NG] Add a sharing NG equivalent for the default_permissions capability  ocis#8741)
• Remove all ShareRoles and rename ShareRoleNG to ShareRole (refactor: remove old share roles #10682)
• Make sure the OCS sharing API isn't being used anymore and remove SDK dependency (refactor: remove owncloud-sdk #10679)
• Merge share/functions.ts and share/functionsNG.ts in web-client (refactor: merge share functions.ts and functionsNG.ts files #10683)

Open questions

• Will there be a share date? ([Sharing NG] Share date is missing in new API ocis#8749)
• How are role names and descriptions being translated in the future?
• Will there be adequate roles and permissions for the different type's of a link?
• Will the dav property PublicLinkPermission on public spaces be translated to type? ([Sharing NG] Replace dav property public-link-permission with type ocis#8740)
• Will the default_permissions in the capabilities be translated to type? ([Sharing NG] Add a sharing NG equivalent for the default_permissions capability  ocis#8741)
• Is it possible to get an icon property for share roles? ([Sharing NG] Add remix icon to share roles ocis#8844)
• What about denied shares, do they work yet? -> no role for this yet
• What about CERN specific features (mainly notification)?

[JammingBen]

I'm closing here since most of the stuff is done. The rest has been converted into single issues meanwhile.