You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With Sharing NG, roles and permissions are coming from the server. While there is a predefined set of available permissions, roles are simply a "bucket" of permissions. In the future we even may have custom roles per instance, which makes it impossible to rely on roles.
Therefore Web should switch its focus on permissions and only use/display role information if the server returns a matching role for a given set of permissions.
Userstory
As an organisation I dont want that fileversions are shared, so that informations are not accidentally revealed.
Rename GraphSharePermission to DriveItemPermission
Remove all role checks (e.g. share.role.id !== GraphShareRoleIdMap.SpaceManager) in favour of permission checks
Remove GraphShareRoleIdMap(?) We might implement something similar for tests though? Now sure...
Re-think the hard-coded keys of the spaceRoles property in the SpaceResource interface. These names can break when the server adds new roles or renames existing.
Make sure that permissions are being displayed in case a set of permissions doesn't have a matching role coming from the server.
How do we display the permissions without cluttering the UI? We probably shouldn't list all permissions coming from the server. @tbsbdr
The text was updated successfully, but these errors were encountered:
tbsbdr
changed the title
[Sharing NG] Make proper use of share permissions instead of roles
[Web & ocis] Make proper use of share permissions instead of roles
Aug 14, 2024
With Sharing NG, roles and permissions are coming from the server. While there is a predefined set of available permissions, roles are simply a "bucket" of permissions. In the future we even may have custom roles per instance, which makes it impossible to rely on roles.
Therefore Web should switch its focus on permissions and only use/display role information if the server returns a matching role for a given set of permissions.
Userstory
Acceptance criteria
GraphSharePermission
(https://github.com/owncloud/web/blob/master/packages/web-client/src/helpers/share/types.ts#L4). Check against ocis to verify this.GraphSharePermission
toDriveItemPermission
share.role.id !== GraphShareRoleIdMap.SpaceManager
) in favour of permission checksGraphShareRoleIdMap
(?) We might implement something similar for tests though? Now sure...spaceRoles
property in theSpaceResource
interface. These names can break when the server adds new roles or renames existing.The text was updated successfully, but these errors were encountered: