Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sharing NG] Add a sharing NG equivalent for the default_permissions capability #8741

Open
JammingBen opened this issue Mar 27, 2024 · 1 comment
Labels

Comments

@JammingBen
Copy link
Contributor

JammingBen commented Mar 27, 2024

Describe the bug

Currently, the capabilities contain default_permissions inside the files_sharing object to determine the default permissions a link should have upon creating. This permission concept is however deprecated and originates from the old OCS API. Hence we need a new sharing NG equivalent, I guess default_type, since this property now determines the permissions of a link.

Steps to reproduce

  1. Check default_permissions inside the capabilities response of the server: https://host.docker.internal:9200/ocs/v1.php/cloud/capabilities

Expected behavior

There is some NG equivalent for the default_permissions (e.g. default_type).

Actual behavior

We only have default_permissions.

cc @rhafer

@JammingBen
Copy link
Contributor Author

@micbar You know my gripes with the link type property, but I guess we will be stuck with it for at least the near future, right?

So I see 2 possible options to solve this issue:

  • Introduce default_type to the capabilities. Possible values are all supported link types.
  • Introduce default_type_internal to the capabilities. Possible values are true or false. This would be a little more restrictive as users can only determine of links will be created with the internal or the view type.

Also, how do you handle deprecated capabilities and env vars in oCIS? Just remove them, or announce the deprecation somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant