refactor: remove aggregateResourceShares and share prop on share resources #10426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
JammingBen
commented
Jan 31, 2024
Comment on lines
-123
to
-126
| const res = unref(resource) | ||
| if (isShareResource(res) && res.share?.role) { | ||
| return res.share.role.hasPermission(SharePermissions.update) | ||
| } |
There was a problem hiding this comment.
File versions currently can't be loaded for shares (including files inside a shared folder), so this check is not needed at the moment. If needed later it should check the graph permissions instead.
7 tasks
JammingBen
force-pushed
the
remove-share-status
branch
from
3443f1c to
8fcd572
Compare
JammingBen
force-pushed
the
remove-share-prop-on-share-resources
branch
2 times, most recently
from
c5c86f8 to
428af50
Compare
Removes the `share` property on `ShareResource` because a) there is no need to expose the full share on a resource and b) a `ShareResource` can "hold" multiple shares, rendering that property useless.
JammingBen
force-pushed
the
remove-share-prop-on-share-resources
branch
from
428af50 to
28f4542
Compare
|
delete-merged-branch
bot
deleted the
remove-share-prop-on-share-resources
branch
saw-jan
added a commit
that referenced
this pull request
Mar 4, 2024
saw-jan
added a commit
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
aggregateResourceSharesbecause we don't need it anymore. The proper way to build share resources is viabuildIncomingShareResourceandbuildOutgoingShareResource.shareproperty onShareResourcebecause a) there is no need to expose the full share on a resource and b) aShareResourcecan "hold" multiple shares, rendering that property basically useless.Related Issue
Types of changes