Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove shares panel separation for details query #10696

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

JammingBen
Copy link
Contributor

Description

Removes the shares panel separation between people and link shares when using the details query param. It's not needed and didn't work before anyway.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Removes the shares panel separation between people and link shares when using the `details` query param.
@JammingBen JammingBen self-assigned this Apr 2, 2024
Copy link

update-docs bot commented Apr 2, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen JammingBen mentioned this pull request Apr 2, 2024
40 tasks
Copy link

sonarcloud bot commented Apr 2, 2024

@JammingBen JammingBen requested a review from kulmann April 2, 2024 13:08
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JammingBen JammingBen merged commit c2308f3 into master Apr 2, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove-shares-panel-separation branch April 2, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants