fix: share indicators for incoming shares #10759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
JammingBen
force-pushed
the
rework-sharing-indicators
branch
4 times, most recently
from
ee6e513 to
786314b
Compare
JammingBen
force-pushed
the
rework-sharing-indicators
branch
from
786314b to
2248e75
Compare
kulmann
suggested changes
Apr 15, 2024
There was a problem hiding this comment.
- If I create a user-share I see a user-share indicator in the file list (correct so far)
- if I then create a link-share, I don't see the user-share indicator anymore, but only the link-share indicator
- both share indicators at the same time are only visible after a page reload / navigation to a different folder and back to the original location
Hmm I can't reproduce this. But I remember seeing this issue a while ago. Anything I'm missing in the steps to reproduce? 🤔 |
kulmann
approved these changes
Apr 17, 2024
Fixes an issue where share indicators would falsely show for and in incoming shares. These are only needed where outgoing shares are being displayed, meaning in project spaces the user has access to and their personal space. Refactoring and clean-up in the course of this: * Introduce a `ResourceStatusIndicator` type * Remove the unnecessary property `target` from status indicators
JammingBen
force-pushed
the
rework-sharing-indicators
branch
from
2248e75 to
31384af
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where share indicators would falsely show for and in incoming shares. These are only needed where outgoing shares are being displayed, meaning in project spaces the user has access to and their personal space.
Refactoring and clean-up in the course of this:
ResourceStatusIndicatortypetargetfrom status indicatorsRelated Issue
Types of changes