Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Add api test for search file through tag #6641

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Jun 27, 2023

Description

This PR adds the API tests for full search api. The scenarios added in this PR are

Related Issue

Motivation and Context

  • there was no test coverage for api test for search file using tag. so, this PR covers the require scenario test case

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 self-assigned this Jun 27, 2023
@owncloud owncloud deleted a comment from update-docs bot Jun 27, 2023
@nabim777 nabim777 changed the title add api test for search file through tag [tests-only][full-ci]Add api test for search file through tag Jun 27, 2023
@nabim777 nabim777 force-pushed the test-api-search-by-tag branch from f6ed615 to fe20831 Compare June 27, 2023 10:47
@nabim777 nabim777 mentioned this pull request Jun 27, 2023
51 tasks
@nabim777 nabim777 force-pushed the test-api-search-by-tag branch from fe20831 to 6493152 Compare June 27, 2023 10:54
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nabim777 nabim777 force-pushed the test-api-search-by-tag branch from 668b8de to 5ba7e88 Compare June 29, 2023 10:00
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@grgprarup grgprarup merged commit cad8668 into master Jun 29, 2023
@delete-merged-branch delete-merged-branch bot deleted the test-api-search-by-tag branch June 29, 2023 10:40
ownclouders pushed a commit that referenced this pull request Jun 29, 2023
[tests-only][full-ci]Add api test for search file through tag
@ScharfViktor
Copy link
Contributor

I would ask about location fullsearch.feature Why did you choose apiGraph suite?

@saw-jan
Copy link
Member

saw-jan commented Jul 4, 2023

I would ask about location fullsearch.feature Why did you choose apiGraph suite?

Should not be any specific reason. But yeah, can move that suite to another location, apiGraph has already many feature files.
CC @nabim777

@ScharfViktor
Copy link
Contributor

Should not be any specific reason. But yeah, can move that suite to another location, apiGraph has already many feature files. CC @nabim777

i moved it here #6716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants