Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Added API test to search for restored resources having tag #6661

Merged
merged 1 commit into from
Jul 13, 2023
Merged

[tests-only][full-ci] Added API test to search for restored resources having tag #6661

merged 1 commit into from
Jul 13, 2023

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Jun 28, 2023 •
edited
Loading

Description

This PR adds the API tests for search restored files through a tag. The scenarios added in this PR are

Related Issue

Motivation and Context

  • there was no test coverage for api test for search restored files through a tag. so, this PR covers the require scenario test case

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 self-assigned this Jun 28, 2023
@nabim777 nabim777 mentioned this pull request Jun 28, 2023
Closed
51 tasks
@SwikritiT
Copy link
Contributor

@nabim777 I see a lot of your PR's dependent to one another please keep the other PR's in draft until the first PR gets merged to prevent accidental merging of one or more PR's before another

@SwikritiT
Copy link
Contributor

Please keep your other PR's in draft and don't ask for reviews as well until this is merged #6641

SwikritiT
SwikritiT suggested changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to prevent accidental merge before the first PR is merged #6641

@nabim777 nabim777 marked this pull request as draft June 29, 2023 09:43
@nabim777 nabim777 force-pushed the test-api-search-restore-resource-having-tag branch 6 times, most recently from 79c0ed5 to 57a5ac4 Compare July 12, 2023 05:09
@nabim777 nabim777 marked this pull request as ready for review July 12, 2023 05:49
@nabim777 nabim777 requested review from SagarGi and SwikritiT July 12, 2023 05:49
@nabim777 nabim777 force-pushed the test-api-search-restore-resource-having-tag branch from 57a5ac4 to e78283d Compare July 12, 2023 05:56
@grgprarup
Copy link
Contributor

@nabim777 Please change the title so that it gives a gist of PR.

@saw-jan saw-jan changed the title [tests-only][full-ci]Test api search restore resource having tag [tests-only][full-ci] Added API test to search for restored resources having tag Jul 12, 2023
SagarGi
SagarGi reviewed Jul 13, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other LGTM 👍

@nabim777 nabim777 force-pushed the test-api-search-restore-resource-having-tag branch from e78283d to 00c507c Compare July 13, 2023 04:27
@nabim777 nabim777 requested review from grgprarup and SagarGi July 13, 2023 04:28
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

SwikritiT
SwikritiT approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan saw-jan merged commit 9ca703f into master Jul 13, 2023
@delete-merged-branch delete-merged-branch bot deleted the test-api-search-restore-resource-having-tag branch July 13, 2023 06:06
ownclouders pushed a commit that referenced this pull request Jul 13, 2023
@nabim777
add api test for search file through tag (#6661)
7597491
@nabim777 nabim777 mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SwikritiT SwikritiT SwikritiT approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@grgprarup grgprarup Awaiting requested review from grgprarup

@SagarGi SagarGi Awaiting requested review from SagarGi

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nabim777 @SwikritiT @grgprarup @SagarGi @saw-jan