Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Test api search by deleted tag #6660

Merged
merged 1 commit into from
Jul 12, 2023
Merged

[tests-only][full-ci]Test api search by deleted tag #6660

merged 1 commit into from
Jul 12, 2023

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Jun 28, 2023 •
edited by saw-jan
Loading

Description

This PR adds the API tests for full search api. The scenarios added in this PR are

Related Issue

Motivation and Context

  • there was no test coverage for api test for search file using deleted tag. so, this PR covers the require scenario test case

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 self-assigned this Jun 28, 2023
@nabim777 nabim777 mentioned this pull request Jun 28, 2023
Closed
51 tasks
@nabim777 nabim777 force-pushed the test-api-search-by-deleted-tag branch from 0097875 to 86ac240 Compare June 28, 2023 12:38
@SwikritiT
Copy link
Contributor

Same for this as well don't ask review until the first PR get's merged #6641

SwikritiT
SwikritiT suggested changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to prevent accidental merge

@nabim777 nabim777 marked this pull request as draft June 29, 2023 09:55
@nabim777 nabim777 force-pushed the test-api-search-by-deleted-tag branch 3 times, most recently from 80e9122 to f8701e7 Compare July 10, 2023 10:04
@nabim777 nabim777 marked this pull request as ready for review July 10, 2023 10:06
@nabim777 nabim777 requested a review from SwikritiT July 10, 2023 10:06
@nabim777 nabim777 force-pushed the test-api-search-by-deleted-tag branch 3 times, most recently from 86ee1a5 to 051b3a4 Compare July 11, 2023 06:27
SagarGi
SagarGi reviewed Jul 11, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nabim777 nabim777 force-pushed the test-api-search-by-deleted-tag branch from 051b3a4 to b4b1c9b Compare July 11, 2023 06:35
@nabim777 nabim777 force-pushed the test-api-search-by-deleted-tag branch 3 times, most recently from 6e4e0cc to c35e834 Compare July 11, 2023 07:02
@nabim777 nabim777 force-pushed the test-api-search-by-deleted-tag branch from c35e834 to 46e606b Compare July 11, 2023 08:46
saw-jan
saw-jan reviewed Jul 11, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabim777 nabim777 force-pushed the test-api-search-by-deleted-tag branch from 46e606b to 520f443 Compare July 12, 2023 04:03
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nabim777 nabim777 merged commit 469341c into master Jul 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the test-api-search-by-deleted-tag branch July 12, 2023 04:49
ownclouders pushed a commit that referenced this pull request Jul 12, 2023
@nabim777
add test for search by deleted tag (#6660)
92e555b
@nabim777 nabim777 mentioned this pull request Jul 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrita-shrestha amrita-shrestha amrita-shrestha left review comments

@saw-jan saw-jan saw-jan left review comments

@SagarGi SagarGi SagarGi left review comments

@SwikritiT SwikritiT SwikritiT approved these changes

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@grgprarup grgprarup Awaiting requested review from grgprarup

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nabim777 @SwikritiT @grgprarup @SagarGi @saw-jan @amrita-shrestha