Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Added API test to search shared items using a tag #6659

Merged
merged 1 commit into from
Jul 10, 2023
Merged

[tests-only][full-ci] Added API test to search shared items using a tag #6659

merged 1 commit into from
Jul 10, 2023

Conversation

nabim777
Copy link
Member

Description

This PR adds the API tests for full search api. The scenarios added in this PR are

  • search by tag accepted sharee

Related Issue

Motivation and Context

  • there was no test coverage for api test for search by tag accepted sharee. so, this PR covers the require scenario test case

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 self-assigned this Jun 28, 2023
@nabim777 nabim777 mentioned this pull request Jun 28, 2023
Closed
51 tasks
SwikritiT
SwikritiT suggested changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here as well don't ask review until the first PR is merged #6641

@nabim777 nabim777 marked this pull request as draft June 29, 2023 09:53
@nabim777 nabim777 force-pushed the test-api-search-by-tag-accepted-share branch from 16c2a1e to 32c1cfb Compare June 30, 2023 08:29
@nabim777 nabim777 marked this pull request as ready for review June 30, 2023 08:29
@nabim777 nabim777 requested a review from SwikritiT June 30, 2023 08:29
grgprarup
grgprarup approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@nabim777 nabim777 force-pushed the test-api-search-by-tag-accepted-share branch 2 times, most recently from f63aa51 to db2e29a Compare July 3, 2023 10:05
@nabim777 nabim777 force-pushed the test-api-search-by-tag-accepted-share branch from 7b04bad to 4a39446 Compare July 3, 2023 10:27
@nabim777 nabim777 force-pushed the test-api-search-by-tag-accepted-share branch from 0531b6b to 2ac6420 Compare July 4, 2023 09:02
grgprarup
grgprarup approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@saw-jan saw-jan changed the title [tests-only][full-ci]Test api search by tag accepted share [tests-only][full-ci] Added API test to search shared items using a tag Jul 4, 2023
saw-jan
saw-jan approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SagarGi SagarGi requested a review from ScharfViktor July 5, 2023 03:32
SagarGi
SagarGi reviewed Jul 5, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SwikritiT
Copy link
Contributor

https://github.com/owncloud/ocis/tree/test-api-search-by-tag-accepted-share
this says that the branch is 11 commits behind

@nabim777 please rebase and push

@nabim777 nabim777 force-pushed the test-api-search-by-tag-accepted-share branch from 68422d2 to 5ff8144 Compare July 5, 2023 03:55
saw-jan
saw-jan requested changes Jul 5, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix the commits

@nabim777 nabim777 force-pushed the test-api-search-by-tag-accepted-share branch 4 times, most recently from d565323 to 093a227 Compare July 6, 2023 03:44
@nabim777 nabim777 force-pushed the test-api-search-by-tag-accepted-share branch 2 times, most recently from 339c38a to f664c70 Compare July 10, 2023 05:01
@nabim777 nabim777 force-pushed the test-api-search-by-tag-accepted-share branch from f664c70 to 68442d6 Compare July 10, 2023 07:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@amrita-shrestha amrita-shrestha requested a review from saw-jan July 10, 2023 08:27
@amrita-shrestha amrita-shrestha merged commit ee1c9cf into master Jul 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the test-api-search-by-tag-accepted-share branch July 10, 2023 08:44
ownclouders pushed a commit that referenced this pull request Jul 10, 2023
@nabim777
add api test for search tag by user (#6659)
7f4fab1
fschade pushed a commit that referenced this pull request Jul 10, 2023
@nabim777 @fschade
add api test for search tag by user (#6659)
774b543
@nabim777 nabim777 mentioned this pull request Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@SwikritiT SwikritiT SwikritiT approved these changes

@grgprarup grgprarup grgprarup approved these changes

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nabim777 @SwikritiT @grgprarup @SagarGi @saw-jan @amrita-shrestha @PrajwolAmatya