Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] Added API test to search shared files by sharee using tag #6653

Merged
merged 2 commits into from
Jun 30, 2023
Merged

[tests-only] [full-ci] Added API test to search shared files by sharee using tag #6653

merged 2 commits into from
Jun 30, 2023

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Jun 28, 2023 •
edited
Loading

Description

This PR adds the API tests for full search api. The scenarios added in this PR are

Related Issue

Motivation and Context

  • there was no test coverage for api test for search file using tag by sharee. so, this PR covers the require scenario test case

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 self-assigned this Jun 28, 2023
@nabim777 nabim777 marked this pull request as ready for review June 28, 2023 11:29
@nabim777 nabim777 mentioned this pull request Jun 28, 2023
Closed
51 tasks
@nabim777 nabim777 force-pushed the test-api-search-tag-by-user branch from 12f2cdc to 47a9d7d Compare June 28, 2023 11:32
SwikritiT
SwikritiT suggested changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't ask reviews in other dependent PR's before the first PR is merged #6641

@nabim777 nabim777 marked this pull request as draft June 29, 2023 09:53
@nabim777 nabim777 force-pushed the test-api-search-tag-by-user branch from 47a9d7d to 59cb991 Compare June 29, 2023 11:41
@nabim777 nabim777 marked this pull request as ready for review June 29, 2023 11:42
@nabim777 nabim777 requested a review from SwikritiT June 29, 2023 11:43
@nabim777 nabim777 requested a review from SwikritiT June 30, 2023 05:41
PrajwolAmatya
PrajwolAmatya reviewed Jun 30, 2023
View reviewed changes
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SwikritiT
Copy link
Contributor

@nabim777 the branch is 14 commits behind master
https://github.com/owncloud/ocis/tree/test-api-search-tag-by-user
please rebase and push

SwikritiT
SwikritiT reviewed Jun 30, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes LGTM

@nabim777 nabim777 force-pushed the test-api-search-tag-by-user branch from 522af1d to aeff317 Compare June 30, 2023 06:02
SwikritiT
SwikritiT approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan changed the title [tests-only] [full-ci]Test api search tag by user [tests-only] [full-ci] Added API test to search shared files by sharee using tag Jun 30, 2023
saw-jan
saw-jan approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan saw-jan merged commit fe02377 into master Jun 30, 2023
ownclouders pushed a commit that referenced this pull request Jun 30, 2023
@nabim777
[tests-only] [full-ci] Added API test to search shared files by share…
a67b627 
…e using tag (#6653)

* add api test for search file through tag

* review addresses
@phil-davis phil-davis deleted the test-api-search-tag-by-user branch July 3, 2023 04:25
@nabim777 nabim777 mentioned this pull request Jul 3, 2023
Merged
9 tasks
fschade pushed a commit that referenced this pull request Jul 10, 2023
@nabim777 @fschade
[tests-only] [full-ci] Added API test to search shared files by share…
96dc9ba 
…e using tag (#6653)

* add api test for search file through tag

* review addresses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrajwolAmatya PrajwolAmatya PrajwolAmatya left review comments

@saw-jan saw-jan saw-jan approved these changes

@SwikritiT SwikritiT SwikritiT approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nabim777 @SwikritiT @saw-jan @PrajwolAmatya