Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile experience very flaky due to snap.js issues #11193

Closed
BernhardPosselt opened this issue Sep 20, 2014 · 9 comments · Fixed by #17785
Closed

Mobile experience very flaky due to snap.js issues #11193

BernhardPosselt opened this issue Sep 20, 2014 · 9 comments · Fixed by #17785

Comments

@BernhardPosselt
Copy link
Contributor

I've been using the new News app release on my mobile phone the last couple of days and the snap.js experience is very flaky:

  • If you scroll down with your finger, the menu shows quite often even if you dont want it. To fix this you need to swipe down from the top left to the bottom right corner to not trigger a left swipe which is kinda weird
  • The flying loading icon issue, same as in Flying Loading Icon notes#64
  • The loading icon and hamburger menu overlap the navigation

All in all I think it would be best to get rid of snap.js (if none of these issues can be fixed in the next couple months) and just use the hamburger button to toggle the right menu, you dont need the menu that often and the hamburger menu is reachable pretty well at all times due to the fixed positioning.

PS: please try out the new News app release, also on your mobile and touch devices :)

@jancborchardt @MorrisJobke @jbtbnl @georgehrke @raghunayyar @PVince81 @th3fallen

@MorrisJobke
Copy link
Contributor

cc @owncloud/designers

@jancborchardt
Copy link
Member

I tried it out with some tablets and smartphones and also found this annoying.

First we should try dialing down the sensitivity of snap.js – swiping is a very common pattern to reveal a menu now and it’s nice for power users.

@BernhardPosselt
Copy link
Contributor Author

Yes, if possible sensitivity should be turned down :)

@PVince81
Copy link
Contributor

CC @schiesbn who showed this to me last week.

@zerosine
Copy link

zerosine commented Jul 1, 2015

I too found this very annoying. The sensitivity was too high.

I was able to adjust the sensitivity a little bit... open snap.js from it's folder:
../core/vendor/snapjs/dist/latest

Under var settings = self.settings = {
find minDragDistance

I changed it's value to 145 and it seems much better.

To disable swiping completely, just change value of touchToDrag to false.

@BernhardPosselt
Copy link
Contributor Author

Btw, it seems much better in 8.1. If anything needs to be fixed at all @zerosine 's fix should be added here https://github.com/owncloud/core/blob/master/core/js/js.js#L1222

@jancborchardt
Copy link
Member

@zerosine can you open a pull request for core with your sensitivity fix? Sounds great

@FINIUS
Copy link

FINIUS commented Jul 21, 2015

on my iOS 8.4 devices I can't see any difference with oc 8.1

@jancborchardt
Copy link
Member

Pull request to fix this at #17785, applying @zerosine’s suggestion. Please test!

MorrisJobke added a commit that referenced this issue Aug 12, 2015
fix mobile scrolling, lower sidebar sensitivity, fix #11193
jancborchardt added a commit that referenced this issue Aug 13, 2015
[stable8.1] fix mobile scrolling, lower sidebar sensitivity, fix #11193
MorrisJobke added a commit that referenced this issue Aug 19, 2015
[stable8] fix mobile scrolling, lower sidebar sensitivity, fix #11193
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants