-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flying Loading Icon #64
Comments
The issue is caused by changes in oc 7 :P |
@Raydiation what kind of answer is that? I also experienced this – it has to do with Snap.js, the library we use for the mobile sidebar. It animates the app-content and for some reason that messes with the background even when on desktop. I played around with it and it seems a solution is to not put the |
Most likely the transition. Can you try if putting a div with ng-view inside the app-content div fixes the issue? |
BTW I've ignored the repo, please try if you can fix it by yourself |
As discussed at the conference I can't maintain it any more |
The answer was meant as a hint to track down the issue |
I will have a look at this sometime. This is also a error in calendar rework. If I am able to fix it there, I will push stuff here as well. :) |
@jancborchardt I have fixed this in calendar rework by introducing another div inside the #app-content div. It's weird that the same fix doesn't work for notes. Will have to dig into this more. cc @Raydiation |
Check the docs in my pull request, maybe you want to backport the #app-content-wrapper |
@Raydiation only if you give me a link ;) |
@Raydiation the hamburger toggle thing in the core has a position fixed and is hence overlapping with the owncloud logo. This I guess will need a PR to the core, as well. |
@raghunayyar while youre at it, can you use a button instead of a div :D (semantically correct and helps accessibility :)) |
@raghunayyar le hamburger owncloud/core#10971 Running into the same issue now in the news dev branch. To fix it I'd have to nest a div inside a div into the #app-content div which seems kinda excessive. It should be enough to add the loading icon to #app-content |
Btw, the culprit is a transition on all properties, you may want to add a bugreport for the js lib and tell it to only transition the styles truly needed |
@Raydiation yup, that’s also what I found. @raghunayyar @Raydiation you wanna report to Snap.js? |
Id be happy if someone else could do it, busy with other things :) |
Such as wisdom teeth extraction xD |
Merged in @raghunayyar’s pull request cause it fixed the issue. |
On my Google Chrome Version: 37.0.2062.94 on Mac OSX Mavericks, I see the spinning wheel / loading icon come fly from the top left to the centre whenever its on the screen.
It should load up just the centre. @owncloud/designers @Raydiation @jancborchardt
The text was updated successfully, but these errors were encountered: