fix mobile scrolling, lower sidebar sensitivity, fix #11193

[jancborchardt]

Attempting to fix #11193 by applying @zerosine’s fix from #11193 (comment)

Please test @owncloud/designers @Raydiation @zerosine @FINIUS

If this works nicely, we should also backport it.

[jancborchardt]

@tflidd @oparoz @SunboX please also test this. :)

[MorrisJobke]

I got a bit less responsive, because the menu reveals instantly after the threshold is reached, which looks a bit clumsy. But now it's easier to scroll downwards.

[jancborchardt]

Maybe we need to play around with some of the other values at

core/core/vendor/snapjs/dist/latest/snap.js

Lines 44 to 61 in 7df96f1

	var settings = self.settings = {
	element: null,
	dragger: null,
	disable: 'none',
	addBodyClasses: true,
	hyperextensible: true,
	resistance: 0.5,
	flickThreshold: 50,
	transitionSpeed: 0.3,
	easing: 'ease',
	maxPosition: 266,
	minPosition: -266,
	tapToClose: true,
	touchToDrag: true,
	clickToDrag: true,
	slideIntent: 40, // degrees
	minDragDistance: 5
	};

For example resistance, flickThreshold and slideIntent.

[FINIUS]

IMHO one can say that side scrolling shouldn't appear as long as your vertical scrolling is more intense. So the side menu should only open if you scroll more horizontal than vertical.
It seems also that some kind of any low "refresh rate" makes scrolling that clumsy

[tflidd]

The initial bug for me was this here: #14639 (menu on the right can't be opened in iOS 8/safari). But OC 7.0.7 and OC 8.1.0 have fixed this (or iOS was fixed). Regarding the menu, it still opens with the fix.

[Bullnados]

On Opera Android looks good. 👍
But perhaps we should reduce the value a little bit. After testing I reduced the value from 145 to 100. With 145 the side menu opened little hard with 100 the sensivity is imo perfect.

[jancborchardt]

@Bullnados great, thanks a lot for testing! :) You are very welcome in our IRC channel #owncloud-design (on freenode) by the way!

[scrutinizer-notifier]

A new inspection was created.

[jancborchardt]

Rebased and applied the change @Bullnados mentioned. Please retest @owncloud/designers @Raydiation @zerosine @FINIUS @tflidd

[ghost]

🚀 Test PASSed.🚀

[jancborchardt]

Please test again so we can merge @Bullnados @MorrisJobke @Raydiation @zerosine @FINIUS @tflidd :)

[MorrisJobke]

Feels better now 👍

[MorrisJobke]

@karlitschek Should we backport this?

@jancborchardt To which versions? I would say 8.1 only.

[jancborchardt]

stable8.1 and stable8 I’d say.

[karlitschek]

Let's backport. 👍

[MorrisJobke]

stable8 #18286
stable8.1 #18284