-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example WDL test for gpu's does not work depending on default executor container #653
Comments
stxue1
changed the title
Example WDL test for gpu's does not work depending on default executor engine
Example WDL test for gpu's does not work depending on default executor container
May 29, 2024
2 tasks
claymcleod
added a commit
that referenced
this issue
Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many (if not all) of the tests were surfaced and reported by @stxue1. The fixes for these tests were a combination of effort from @stxue1 and @jdidion. @adamnovak added feedback on the PR that further refined the tests. @claymcleod did the final review and merge of the pull request in Closes #653. Closes #654. Closes #661. Closes #662. Closes #663. Closes #664. Closes #665. Closes #666. Closes #667. Closes #668. Co-authored-by: Clay McLeod <[email protected]> Co-authored-by: John Didion <[email protected]> Co-authored-by: Adam Novak <[email protected]>
claymcleod
added a commit
that referenced
this issue
Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many (if not all) of the tests were surfaced and reported by @stxue1. The fixes for these tests were a combination of effort from @stxue1 and @jdidion. @adamnovak added feedback on the PR that further refined the tests. @claymcleod did the final review and merge of the pull request in #669. Closes #653. Closes #654. Closes #661. Closes #662. Closes #663. Closes #664. Closes #665. Closes #666. Closes #667. Closes #668. Co-authored-by: Clay McLeod <[email protected]> Co-authored-by: John Didion <[email protected]> Co-authored-by: Adam Novak <[email protected]>
claymcleod
added a commit
that referenced
this issue
Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many (if not all) of the tests were surfaced and reported by @stxue1. The fixes for these tests were a combination of effort from @stxue1 and @jdidion. @adamnovak added feedback on the PR that further refined the tests. @claymcleod did the final review and merge of the pull request in #669. Closes #653. Closes #654. Closes #661. Closes #662. Closes #663. Closes #664. Closes #665. Closes #666. Closes #667. Closes #668. Co-authored-by: Clay McLeod <[email protected]> Co-authored-by: John Didion <[email protected]> Co-authored-by: Adam Novak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the
test_gpu_task.wdl
example test, it depends on thelspci
command from the default executor container as no container is specified.For MiniWDL and Toil, the default container is Ubuntu 20.04:
https://github.com/chanzuckerberg/miniwdl/blob/a34aa902ec1be2f411db1e38daf51bae4f839f42/WDL/runtime/config_templates/default.cfg#L144-L146
But the base Ubuntu 20.04 doesn't support
lspci
:I think some container with
lspci
preinstalled should be specified. Ex:and
which allows the test to run:
The text was updated successfully, but these errors were encountered: