-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing input in allow_nested.wdl unit test #664
Comments
claymcleod
added a commit
that referenced
this issue
Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many (if not all) of the tests were surfaced and reported by @stxue1. The fixes for these tests were a combination of effort from @stxue1 and @jdidion. @adamnovak added feedback on the PR that further refined the tests. @claymcleod did the final review and merge of the pull request in Closes #653. Closes #654. Closes #661. Closes #662. Closes #663. Closes #664. Closes #665. Closes #666. Closes #667. Closes #668. Co-authored-by: Clay McLeod <[email protected]> Co-authored-by: John Didion <[email protected]> Co-authored-by: Adam Novak <[email protected]>
claymcleod
added a commit
that referenced
this issue
Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many (if not all) of the tests were surfaced and reported by @stxue1. The fixes for these tests were a combination of effort from @stxue1 and @jdidion. @adamnovak added feedback on the PR that further refined the tests. @claymcleod did the final review and merge of the pull request in #669. Closes #653. Closes #654. Closes #661. Closes #662. Closes #663. Closes #664. Closes #665. Closes #666. Closes #667. Closes #668. Co-authored-by: Clay McLeod <[email protected]> Co-authored-by: John Didion <[email protected]> Co-authored-by: Adam Novak <[email protected]>
claymcleod
added a commit
that referenced
this issue
Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many (if not all) of the tests were surfaced and reported by @stxue1. The fixes for these tests were a combination of effort from @stxue1 and @jdidion. @adamnovak added feedback on the PR that further refined the tests. @claymcleod did the final review and merge of the pull request in #669. Closes #653. Closes #654. Closes #661. Closes #662. Closes #663. Closes #664. Closes #665. Closes #666. Closes #667. Closes #668. Co-authored-by: Clay McLeod <[email protected]> Co-authored-by: John Didion <[email protected]> Co-authored-by: Adam Novak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For the
allow_nested.wdl
unit test, these lines call a task and omits a required input:wdl/SPEC.md
Lines 5655 to 5658 in 9c0b9cf
This line clarifies that with
allowNestedInputs
directive, this input can be supplied elsewhere:However, for the unit test, I don't see this input being passed through:
wdl/SPEC.md
Lines 5677 to 5685 in 9c0b9cf
Instead, there is an expected output that wants the same variable:
wdl/SPEC.md
Line 5693 in 9c0b9cf
As I don't see where
repeat2.i
is defined in the workflow/input JSON, it looks like that line in the example output JSON should be moved to the example input JSON; the spec also doesn't say (at least to my knowledge) that the execution engine should output certain task inputs from nested calls when there is a output section.The text was updated successfully, but these errors were encountered: