Skip to content

Commit

Permalink
fix: fixes several issues with tests within the specification
Browse files Browse the repository at this point in the history
This commit fixes multiple issues in the `v1.1.*` specification. Many
(if not all) of the tests were surfaced and reported by @stxue1. The
fixes for these tests were a combination of effort from @stxue1 and
@jdidion. @adamnovak added feedback on the PR that further refined the
tests. @claymcleod did the final review and merge of the pull request
in #669.

Closes #653.
Closes #654.
Closes #661.
Closes #662.
Closes #663.
Closes #664.
Closes #665.
Closes #666.
Closes #667.
Closes #668.

Co-authored-by: Clay McLeod <[email protected]>
Co-authored-by: John Didion <[email protected]>
Co-authored-by: Adam Novak <[email protected]>
  • Loading branch information
4 people committed Jan 24, 2025
1 parent 9c0b9cf commit d5fb794
Show file tree
Hide file tree
Showing 3 changed files with 156 additions and 123 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ version development
consist of multiple files.
[PR 241](https://github.com/openwdl/wdl/pull/241) by @cjllanwarne.

version 1.1.3
---------------------------

* Fix issues with examples (#653, #654, #661, #662, #663, #664, #665, #666, #668, #671). Thanks to @stxue1!
* Clarify that a file is not required to exist or be accessible until and unless it is accessed.

version 1.1.2
---------------------------

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ The WDL *language* has a two-number version (e.g., `1.1`).
An increase in the minor (second) version number (e.g., `1.0` to `1.1`) indicates the addition of, or non-breaking changes to, the language or standard library functions.
An increase in the major (first) version number (e.g., `1.0` to `2.0`) indicates that breaking changes have been made.

The WDL *specification* has a three-number version (e.g., `1.1.2`).
The WDL *specification* has a three-number version (e.g., `1.1.3`).
The specification version tracks the language version, but there may also be patch releases (indicated by a change to the patch, or third, version number) that include fixes for typos, additional examples, or non-breaking clarifications of ambiguous language.

## Language Specifications
Expand Down
Loading

0 comments on commit d5fb794

Please sign in to comment.