Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatched variable names in test_prefix.wdl unit test #666

Open
stxue1 opened this issue Jun 18, 2024 · 1 comment
Open

Mismatched variable names in test_prefix.wdl unit test #666

stxue1 opened this issue Jun 18, 2024 · 1 comment
Assignees

Comments

@stxue1
Copy link
Collaborator

stxue1 commented Jun 18, 2024

The test_prefix.wdl unit test has a workflow output env_prefixed:

wdl/SPEC.md

Line 8093 in 9c0b9cf

Array[String] env_prefixed = prefix("-e ", env1)

But the expected output is env1_prefixed:

wdl/SPEC.md

Line 8110 in 9c0b9cf

"test_prefix.env1_prefixed": ["-e key1=value1", "-e key2=value2", "-e key3=value3"],

@stxue1
Copy link
Collaborator Author

stxue1 commented Jun 18, 2024

A similar issue is in the serialize_array_delim_task.wdl test. heads is the output in the workflow:

wdl/SPEC.md

Line 9844 in 9c0b9cf

Array[String] heads = read_lines(stdout())

And the expected output is strings:

wdl/SPEC.md

Line 9867 in 9c0b9cf

"serialize_array_delim.strings": [

jdidion added a commit that referenced this issue Jun 26, 2024
jdidion added a commit that referenced this issue Jun 26, 2024
jdidion added a commit that referenced this issue Jun 26, 2024
@jdidion jdidion self-assigned this Jun 26, 2024
claymcleod added a commit that referenced this issue Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many
(if not all) of the tests were surfaced and reported by @stxue1. The
fixes for these tests were a combination of effort from @stxue1 and
@jdidion. @adamnovak added feedback on the PR that further refined the
tests. @claymcleod did the final review and merge of the pull request in

Closes #653.
Closes #654.
Closes #661.
Closes #662.
Closes #663.
Closes #664.
Closes #665.
Closes #666.
Closes #667.
Closes #668.

Co-authored-by: Clay McLeod <[email protected]>
Co-authored-by: John Didion <[email protected]>
Co-authored-by: Adam Novak <[email protected]>
claymcleod added a commit that referenced this issue Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many
(if not all) of the tests were surfaced and reported by @stxue1. The
fixes for these tests were a combination of effort from @stxue1 and
@jdidion. @adamnovak added feedback on the PR that further refined the
tests. @claymcleod did the final review and merge of the pull request
in #669.

Closes #653.
Closes #654.
Closes #661.
Closes #662.
Closes #663.
Closes #664.
Closes #665.
Closes #666.
Closes #667.
Closes #668.

Co-authored-by: Clay McLeod <[email protected]>
Co-authored-by: John Didion <[email protected]>
Co-authored-by: Adam Novak <[email protected]>
claymcleod added a commit that referenced this issue Jan 24, 2025
This commit fixes multiple issues in the `v1.1.*` specification. Many
(if not all) of the tests were surfaced and reported by @stxue1. The
fixes for these tests were a combination of effort from @stxue1 and
@jdidion. @adamnovak added feedback on the PR that further refined the
tests. @claymcleod did the final review and merge of the pull request
in #669.

Closes #653.
Closes #654.
Closes #661.
Closes #662.
Closes #663.
Closes #664.
Closes #665.
Closes #666.
Closes #667.
Closes #668.

Co-authored-by: Clay McLeod <[email protected]>
Co-authored-by: John Didion <[email protected]>
Co-authored-by: Adam Novak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants