Specify container with lspci for GPU WDL example.
#659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdidion
reviewed
Jun 25, 2024
jdidion
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #653.
The
test_gpu_task.wdlexample assumes that thelspcicommand exists in the task environment. However, the SPEC also says the default container when it is unspecified is up to the engine.I'm assuming that the default container for an engine doesn't need to provide the
lspcicommand. I grabbed a docker container that should be decently up to date, maintained, and provideslspciso the test should be working out of the box after this PR.I'm not making a changelog entry as I think this is just a bug fix.
Checklist