Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual backport] Backport doctest fix to 2.x #3086

Closed

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Oct 21, 2024

Description

Not sure why so much documentation is merge conflicting, but here we are. Backports #3053

Related Issues

N/A

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

opensearch-trigger-bot bot and others added 30 commits July 11, 2023 17:50
…pensearch-project#1853)

* Remov:e Default master key (opensearch-project#1851)

Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit bc02815)

* Fix BWC tests

Signed-off-by: Vamsi Manohar <[email protected]>

---------

Signed-off-by: Vamsi Manohar <[email protected]>
Co-authored-by: Vamsi Manohar <[email protected]>
)

Signed-off-by: Yury-Fridlyand <[email protected]>
(cherry picked from commit f5031a7)

Co-authored-by: Yury-Fridlyand <[email protected]>
…ct#1858)

Signed-off-by: Max Ksyunz <[email protected]>
(cherry picked from commit e186cf7)

Co-authored-by: Max Ksyunz <[email protected]>
…opensearch-project#296) (opensearch-project#1891)

* Fix core refactor: StreamIO from common to core.common (opensearch-project#296) (opensearch-project#1869)

* Fix core refactor: StreamIO from common to core.common

* Fix core refactor: StreamIO from common to core.common

---------

Signed-off-by: acarbonetto <[email protected]>
(cherry picked from commit dae5a85)

* Bump Version and Fix import error

Signed-off-by: Vamsi Manohar <[email protected]>

---------

Signed-off-by: Vamsi Manohar <[email protected]>
Co-authored-by: Andrew Carbonetto <[email protected]>
Co-authored-by: Vamsi Manohar <[email protected]>
…search-project#1890)

Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit 4102b58)

Co-authored-by: Vamsi Manohar <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
…project#283) (opensearch-project#1852)

* Added new datetime functions, documentation, and tests

Signed-off-by: Matthew Wells <[email protected]>
(cherry picked from commit 8c8e08c)
…ckport/backport-1852-to-2.x

[Backport 2.x] Added new datetime functions and aliases to PPL [Part 2]
…ckport-1888-to-2.x

[Backport 2.x] Adding Spotless support framework opensearch-project#1888
…ckport/backport-1885-to-2.x

[Backport 2.x] Fixed missing underscores in day_of_week doctest
…ckport/backport-1897-to-2.x

[Backport 2.x] Statically init `typeActionMap` in `OpenSearchExprValueFactory`.
…ets (opensearch-project#1908)

* Added support of timestamp/date/time using curly brackets (opensearch-project#1894)

* Added support of timestamp/date/time using curly brackets (opensearch-project#297)

* added bracketed time/date/timestamp input, tests, and documentation

Signed-off-by: Matthew Wells <[email protected]>

* improved failing tests

Signed-off-by: Matthew Wells <[email protected]>

* simplified tests for checking for failure

Signed-off-by: Matthew Wells <[email protected]>

* fixed redundant tests and improved tests that should fail

Signed-off-by: Matthew Wells <[email protected]>

---------

Signed-off-by: Matthew Wells <[email protected]>
(cherry picked from commit 1a7134b)

* fixed bad cherrypick merge conflict

Signed-off-by: Matthew Wells <[email protected]>

---------

Signed-off-by: Matthew Wells <[email protected]>
* Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (opensearch-project#1899)

* Added setDefaultMediaType for create_index and create_index_with_IOException

Signed-off-by: Mitchell Gale <[email protected]>
(cherry picked from commit 7b932a7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix renamed imports (opensearch-project#1911)

Signed-off-by: Yury-Fridlyand <[email protected]>

* Merge pull request opensearch-project#1914 from Bit-Quill/fix-breaking-changes-Nth-time

Fix breaking changes.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Fixed imports (opensearch-project#1919)

Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Guian Gumpac <[email protected]>
… (opensearch-project#1925)

* Adding spotless plugin to project build.gradle.



Remove commented out spotless changes.



Adding Spotless to DEVELOPER_GUIDE.rst



Added Google Java format to spotless.



Update DEVELOPER_GUIDE.rst



* Added apply false for spotless



* Adding ratchetFrom to build.gradle



* Adding license header to build.gradle for spotless.



* Uncommenting all changes to build.gradle for spotless.



* Commented out spotless checks.



* Add specific version for java format spotless (1.17.0)



* Add spotless end with new line check.



* Add new line at end of files missing lines.



* Removed include path



* Correcting ending new line for QueryExemplars.



---------




(cherry picked from commit d2de909)

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Yury-Fridlyand <[email protected]>
…ect#1946)

* Fixing strings change from main OS repo.



* Fixing issues.



* Fixing changed syntax to toStirng.



* Fixing changed syntax to toStirng.



* add tosttring fix to RestSQLQueryActionCursorFallbackTest



* added unused function



---------

Signed-off-by: Mitchell Gale <[email protected]>
(cherry picked from commit 3db0d4f)

Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…cludes to builder (opensearch-project#1937) (opensearch-project#1948)

* opensearch-project#1536: Refactor OpenSearchQueryRequest and move includes to builder (opensearch-project#320)

* opensearch-project#1536: Refactor OpenSearchQueryRequest and move incldues to builder



* opensearch-project#1536: Checkstyle fixes



* opensearch-project#1536: Checkstyle fixes



---------



* opensearch-project#1536: Spotless Apply



---------


(cherry picked from commit 7d23e0f)

Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
)

* okio upgrade to 3.5.0



* remove empty line



* removed kotlin-stdlib resolution



* upgrade kotlin stdlib to 1.9.0



---------


(cherry picked from commit c99549a)

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…-project#1958) (opensearch-project#1965)

* fixing breaking change before ML fix.



* More fixes for core breaking change.



* spotless apply.



* Remove d L at end of actionGet int



* Adding missed import updates for ElasticDefaultRestExecutor and OpenSearchDataSourceMetadataStorageTest.java



* Adding missed import updates for SparkResponse.java



* Adding missed import updates for BindingTupleQueryPlannerExecuteTest CheckScriptContents QueryPlannerTest.java SparkResponseTest.java



---------

Signed-off-by: Mitchell Gale <[email protected]>
… HIDDEN_FIELD_NAME (opensearch-project#1936) (opensearch-project#1964)

* (opensearch-project#1506) Remove reservedSymbolTable and replace with HIDDEN_FIELD_NAME (opensearch-project#323)

* opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead



* opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead



* opensearch-project#1506: Fix checkstyle errors



---------



* opensearch-project#1506: spotless apply



---------


(cherry picked from commit 5381a6f)

Signed-off-by: acarbonetto <[email protected]>
(cherry picked from commit ff059f0)

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…in files opensearch-project#3 (opensearch-project#1932) (opensearch-project#1994)

* [Spotless] Applying Google Code Format for core/src/main files opensearch-project#3 (opensearch-project#1932)

* Applying Google Java code format changes to core/src/main/java/org/opensearch/sql/planner core/src/main/java/org/opensearch/sql/storage core/src/main/java/org/opensearch/sql/utils

Signed-off-by: Mitchell Gale <[email protected]>

* Ignore on failure for checkstyle in core and added the three spotless fixes files.

Signed-off-by: Mitchell Gale <[email protected]>

* Fixed javadoc formatting in LogicalPlanOptimizer.java LogicalValues.java OperatorUtils.java Planner.java

Signed-off-by: Mitchell Gale <[email protected]>

* spotless apply, fixing include for spotless build.gradle and adding pre tag.

Signed-off-by: Mitchell Gale <[email protected]>

* addressed PR comments.

Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>

* spotless apply

Signed-off-by: Mitchell Gale <[email protected]>

* add checkstyle ignore

Signed-off-by: Mitchell Gale <[email protected]>

* addressed PR comments

Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
opensearch-project#2004)

* Added spotless java format rules to dev guide



* Fixed formatting of URLS in DEVELOPER_GUIDE.rst



* addressed PR comments



* addressed PR comments



* addressed PR comments



* Update DEVELOPER_GUIDE.rst




* Update DEVELOPER_GUIDE.rst




* Update DEVELOPER_GUIDE.rst




* Update DEVELOPER_GUIDE.rst




* Update DEVELOPER_GUIDE.rst




* fixed link format



---------




(cherry picked from commit 8f650e8)

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Yury-Fridlyand <[email protected]>
…in files opensearch-project#4 opensearch-project#1933 (opensearch-project#1995)

* [Spotless] Applying Google Code Format for core/src/main files opensearch-project#4  (opensearch-project#1933)

* GJF part 4

Signed-off-by: Mitchell Gale <[email protected]>

* add build.gradle comment to mention why we are ignoring checkstyle failures for core.

Signed-off-by: Mitchell Gale <[email protected]>

* Fix include spotless build gradle.

Signed-off-by: Mitchell Gale <[email protected]>

* revert astDSL.JAVA

Signed-off-by: Mitchell Gale <[email protected]>

* revert ast changes as was covered in spotless opensearch-project#1 PR for GJF.

Signed-off-by: Mitchell Gale <[email protected]>

* Reverting commits in ast folder attempt opensearch-project#2

Signed-off-by: Mitchell Gale <[email protected]>

* revert change to RaretopN.java

Signed-off-by: Mitchell Gale <[email protected]>

* addressed PR comments.

Signed-off-by: Mitchell Gale <[email protected]>

* Replacing removed include in spotless.

Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>

* spotless apply

Signed-off-by: Mitchell Gale <[email protected]>

* addressed PR comments

Signed-off-by: Mitchell Gale <[email protected]>

* remove pitest

Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
…in files opensearch-project#2 opensearch-project#1931 (opensearch-project#1993)

* [Spotless] Applying Google Code Format for core/src/main files opensearch-project#2 (opensearch-project#1931)

* Applied spotless changes to `core/stc/main/.../expression` and more.

Signed-off-by: Mitchell Gale <[email protected]>

* Applied all spotless for PR 2 for GJF

Signed-off-by: Mitchell Gale <[email protected]>

* Apply spotless to fix custom fixes.

Signed-off-by: Mitchell Gale <[email protected]>

* Remove unused <br>

Signed-off-by: Mitchell Gale <[email protected]>

* ignoring core checkstyle failures.

Signed-off-by: Mitchell Gale <[email protected]>

* addressed PR comments.

Signed-off-by: Mitchell Gale <[email protected]>

* Addressing PR 2 comments.

Signed-off-by: Mitchell Gale <[email protected]>

* Ran spotless apply

Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>

* spotless apply

Signed-off-by: Mitchell Gale <[email protected]>

* address pr comments

Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
opensearch-trigger-bot bot and others added 8 commits September 10, 2024 07:23
…xception (opensearch-project#2986) (opensearch-project#3006)

(cherry picked from commit c22929b)

Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
…nsearch-project#3020)

Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Peng Huo <[email protected]>
…#3039) (opensearch-project#3044)

* Implement SQL validation based on grammar element



* Add function types



* fix style



* Add security lake



* Add File support



* Integrate into SparkQueryDispatcher



* Fix style



* Add tests



* Integration



* Add comments



* Address comments



* Allow join types for now



* Fix style



* Fix coverage check



---------


(cherry picked from commit a87893a)

Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: opensearch-ci-bot <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.