[Backport 2.x] Added support of timestamp/date/time using curly brackets #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewryanwells
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
|
Something wrong with doctests @matthewryanwells |
Codecov Report
@@ Coverage Diff @@
## 2.x #1908 +/- ##
=========================================
Coverage 97.42% 97.42%
Complexity 4648 4648
=========================================
Files 408 408
Lines 11528 11528
Branches 839 839
=========================================
Hits 11231 11231
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was due to a bad cherry pick I had done, it is fixed now |
GumpacG
approved these changes
Jul 27, 2023
MitchellGale
approved these changes
Jul 27, 2023
acarbonetto
reviewed
Jul 27, 2023
acarbonetto
approved these changes
Jul 27, 2023
Yury-Fridlyand
approved these changes
Jul 27, 2023
…-project#1894) * Added support of timestamp/date/time using curly brackets (#297) * added bracketed time/date/timestamp input, tests, and documentation Signed-off-by: Matthew Wells <[email protected]> * improved failing tests Signed-off-by: Matthew Wells <[email protected]> * simplified tests for checking for failure Signed-off-by: Matthew Wells <[email protected]> * fixed redundant tests and improved tests that should fail Signed-off-by: Matthew Wells <[email protected]> --------- Signed-off-by: Matthew Wells <[email protected]> (cherry picked from commit 1a7134b)
Signed-off-by: Matthew Wells <[email protected]>
matthewryanwells
force-pushed
the
backport/backport-1894-to-2.x
branch
from
e42e6b3 to
0c747a8
Compare
Yury-Fridlyand
approved these changes
Jul 27, 2023
|
After rebasing my code again with the most recent changes it has fixed the code coverage issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1a7134b from #1894