Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing underscores in day_of_week doctest #1885

Merged

Conversation

matthewryanwells
Copy link
Contributor

Description

Fixed the day_of_week PPL doctest accidentally calling the dayofweek function instead

Issues Resolved

No related issues

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #1885 (363a6f4) into main (f4883c9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1885   +/-   ##
=========================================
  Coverage     97.39%   97.39%           
  Complexity     4608     4608           
=========================================
  Files           401      401           
  Lines         11408    11408           
  Branches        843      843           
=========================================
  Hits          11111    11111           
  Misses          290      290           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Yury-Fridlyand Yury-Fridlyand merged commit f92e48c into opensearch-project:main Jul 19, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the integ-day_of_week-fix branch July 19, 2023 20:49
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 19, 2023
Signed-off-by: Matthew Wells <[email protected]>
(cherry picked from commit f92e48c)
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 20, 2023
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 20, 2023
matthewryanwells added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 20, 2023
Yury-Fridlyand pushed a commit that referenced this pull request Jul 27, 2023
Signed-off-by: Matthew Wells <[email protected]>
(cherry picked from commit f92e48c)
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants