[Spotless] Adds new line at end of java files #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mitchell Gale <[email protected]> Remove commented out spotless changes. Signed-off-by: Mitchell Gale <[email protected]> Adding Spotless to DEVELOPER_GUIDE.rst Signed-off-by: Mitchell Gale <[email protected]> Added Google Java format to spotless. Signed-off-by: Mitchell Gale <[email protected]> Update DEVELOPER_GUIDE.rst Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Adds Spotless code formatter
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
[Spotless] Adds new line at end of java files
MitchellGale
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey and
acarbonetto
as code owners
Yury-Fridlyand
previously approved these changes
Jul 24, 2023
GumpacG
previously approved these changes
Jul 24, 2023
matthewryanwells
approved these changes
Jul 24, 2023
Signed-off-by: Mitchell Gale <[email protected]>
MitchellGale
dismissed stale reviews from GumpacG and Yury-Fridlyand
via
b9e63c7
6 tasks
Codecov Report
@@ Coverage Diff @@
## main #1896 +/- ##
=========================================
Coverage 97.42% 97.42%
Complexity 4647 4647
=========================================
Files 408 408
Lines 11526 11526
Branches 839 839
=========================================
Hits 11229 11229
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Could you resolve conflicts? |
Signed-off-by: Mitchell Gale <[email protected]>
Resolved. |
Signed-off-by: Mitchell Gale <[email protected]>
Yury-Fridlyand
approved these changes
Jul 31, 2023
6 tasks
acarbonetto
approved these changes
Aug 3, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
* Adding spotless plugin to project build.gradle. Signed-off-by: Mitchell Gale <[email protected]> Remove commented out spotless changes. Signed-off-by: Mitchell Gale <[email protected]> Adding Spotless to DEVELOPER_GUIDE.rst Signed-off-by: Mitchell Gale <[email protected]> Added Google Java format to spotless. Signed-off-by: Mitchell Gale <[email protected]> Update DEVELOPER_GUIDE.rst Co-authored-by: Yury-Fridlyand <[email protected]> * Added apply false for spotless Signed-off-by: Mitchell Gale <[email protected]> * Adding ratchetFrom to build.gradle Signed-off-by: Mitchell Gale <[email protected]> * Adding license header to build.gradle for spotless. Signed-off-by: Mitchell Gale <[email protected]> * Uncommenting all changes to build.gradle for spotless. Signed-off-by: Mitchell Gale <[email protected]> * Commented out spotless checks. Signed-off-by: Mitchell Gale <[email protected]> * Add specific version for java format spotless (1.17.0) Signed-off-by: Mitchell Gale <[email protected]> * Add spotless end with new line check. Signed-off-by: Mitchell Gale <[email protected]> * Add new line at end of files missing lines. Signed-off-by: Mitchell Gale <[email protected]> * Removed include path Signed-off-by: Mitchell Gale <[email protected]> * Correcting ending new line for QueryExemplars. Signed-off-by: Mitchell Gale <[email protected]> --------- Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> (cherry picked from commit d2de909) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
MitchellGale
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Aug 3, 2023
* Adding spotless plugin to project build.gradle. Signed-off-by: Mitchell Gale <[email protected]> Remove commented out spotless changes. Signed-off-by: Mitchell Gale <[email protected]> Adding Spotless to DEVELOPER_GUIDE.rst Signed-off-by: Mitchell Gale <[email protected]> Added Google Java format to spotless. Signed-off-by: Mitchell Gale <[email protected]> Update DEVELOPER_GUIDE.rst Co-authored-by: Yury-Fridlyand <[email protected]> * Added apply false for spotless Signed-off-by: Mitchell Gale <[email protected]> * Adding ratchetFrom to build.gradle Signed-off-by: Mitchell Gale <[email protected]> * Adding license header to build.gradle for spotless. Signed-off-by: Mitchell Gale <[email protected]> * Uncommenting all changes to build.gradle for spotless. Signed-off-by: Mitchell Gale <[email protected]> * Commented out spotless checks. Signed-off-by: Mitchell Gale <[email protected]> * Add specific version for java format spotless (1.17.0) Signed-off-by: Mitchell Gale <[email protected]> * Add spotless end with new line check. Signed-off-by: Mitchell Gale <[email protected]> * Add new line at end of files missing lines. Signed-off-by: Mitchell Gale <[email protected]> * Removed include path Signed-off-by: Mitchell Gale <[email protected]> * Correcting ending new line for QueryExemplars. Signed-off-by: Mitchell Gale <[email protected]> --------- Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]>
acarbonetto
pushed a commit
that referenced
this pull request
Aug 4, 2023
* Adding spotless plugin to project build.gradle. Remove commented out spotless changes. Adding Spotless to DEVELOPER_GUIDE.rst Added Google Java format to spotless. Update DEVELOPER_GUIDE.rst * Added apply false for spotless * Adding ratchetFrom to build.gradle * Adding license header to build.gradle for spotless. * Uncommenting all changes to build.gradle for spotless. * Commented out spotless checks. * Add specific version for java format spotless (1.17.0) * Add spotless end with new line check. * Add new line at end of files missing lines. * Removed include path * Correcting ending new line for QueryExemplars. --------- (cherry picked from commit d2de909) Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new line at end of files missing it. Uncommented spotless line for verification.
Note: line endings updated from
/r/nto/nincommon/src/main/java/org/opensearch/sql/common/grok/Converter.javaRelated to:
#1888
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.