Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing comments on 2.9 release notes #1863

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Addressing comments on 2.9 release notes #1863

merged 1 commit into from
Jul 18, 2023

Conversation

MaxKsyunz
Copy link
Collaborator

Addressing comments on 2.9 release notes.

@codecov
Copy link

codecov bot commented Jul 12, 2023 •
edited
Loading

Codecov Report

Merging #1863 (aaccdbb) into main (fa51012) will increase coverage by 2.59%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1863      +/-   ##
============================================
+ Coverage     97.39%   99.98%   +2.59%     
+ Complexity     4602     2624    -1978     
============================================
  Files           401      205     -196     
  Lines         11386     5955    -5431     
  Branches        843      378     -465     
============================================
- Hits          11089     5954    -5135     
+ Misses          290        1     -289     
+ Partials          7        0       -7
Flag Coverage Δ
sql-engine 99.98% <ø> (+2.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 196 files with indirect coverage changes

Yury-Fridlyand
Yury-Fridlyand reviewed Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM, but I want to ensure that log4j doesn't come to 2.9.
Waiting for opensearch-project/OpenSearch#8667 (comment) and #1861

release-notes/opensearch-sql.release-notes-2.9.0.0.md
@@ -31,14 +31,15 @@ Compatible with OpenSearch and OpenSearch Dashboards Version 2.9.0

* Updated documentation of round function return type ([#1725](https://github.com/opensearch-project/sql/pull/1725))
* Updated `protocol.rst` with new wording for error message ([#1662](https://github.com/opensearch-project/sql/pull/1662))
* Updated documentation for temporal data types ([#1826](https://github.com/opensearch-project/sql/pull/1826))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add #1857/#1863 here?

@Yury-Fridlyand
Copy link
Collaborator

Yury-Fridlyand commented Jul 12, 2023 •
edited
Loading

@MaxKsyunz
You need to include #1848 as well

UPD
No

@MaxKsyunz MaxKsyunz closed this Jul 18, 2023
@MaxKsyunz MaxKsyunz reopened this Jul 18, 2023
@MaxKsyunz MaxKsyunz merged commit 761e6a4 into opensearch-project:main Jul 18, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 18, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 18, 2023
@MaxKsyunz @github-actions
Addressing comments on 2.9 release note (#1863)
067c4f9 
Signed-off-by: Max Ksyunz <[email protected]>
(cherry picked from commit 761e6a4)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 18, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 18, 2023
@MaxKsyunz @github-actions
Addressing comments on 2.9 release note (#1863)
570d743 
Signed-off-by: Max Ksyunz <[email protected]>
(cherry picked from commit 761e6a4)
MaxKsyunz added a commit that referenced this pull request Jul 18, 2023
@opensearch-trigger-bot @MaxKsyunz
Addressing comments on 2.9 release note (#1863) (#1879)
9eb2c4f 
Signed-off-by: Max Ksyunz <[email protected]>
(cherry picked from commit 761e6a4)

Co-authored-by: Max Ksyunz <[email protected]>
matthewryanwells pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 18, 2023
@MaxKsyunz @matthewryanwells
Addressing comments on 2.9 release note (opensearch-project#1863)
d443cf0 
Signed-off-by: Max Ksyunz <[email protected]>
matthewryanwells pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 19, 2023
@MaxKsyunz @matthewryanwells
Addressing comments on 2.9 release note (opensearch-project#1863)
c583000 
Signed-off-by: Max Ksyunz <[email protected]>
Signed-off-by: Matthew Wells <[email protected]>
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 20, 2023
@MaxKsyunz @MitchellGale
Addressing comments on 2.9 release note (opensearch-project#1863)
63ed7e4 
Signed-off-by: Max Ksyunz <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 20, 2023
@MaxKsyunz @MitchellGale
Addressing comments on 2.9 release note (opensearch-project#1863)
00ffa32 
Signed-off-by: Max Ksyunz <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Yury-Fridlyand pushed a commit that referenced this pull request Jul 27, 2023
@MaxKsyunz @Yury-Fridlyand
Addressing comments on 2.9 release note (#1863)
c67b4c4 
Signed-off-by: Max Ksyunz <[email protected]>
(cherry picked from commit 761e6a4)
MaxKsyunz added a commit that referenced this pull request Jul 27, 2023
@opensearch-trigger-bot @MaxKsyunz
Addressing comments on 2.9 release note (#1863) (#1878)
4b1d70e 
Signed-off-by: Max Ksyunz <[email protected]>
(cherry picked from commit 761e6a4)

Co-authored-by: Max Ksyunz <[email protected]>
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 28, 2023
@MaxKsyunz @MitchellGale
Addressing comments on 2.9 release note (opensearch-project#1863)
e60bea4 
Signed-off-by: Max Ksyunz <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand left review comments

@matthewryanwells matthewryanwells matthewryanwells approved these changes

@MitchellGale MitchellGale MitchellGale approved these changes

@acarbonetto acarbonetto acarbonetto approved these changes

@forestmvey forestmvey forestmvey approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vmmusings vmmusings Awaiting requested review from vmmusings

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MaxKsyunz @Yury-Fridlyand @forestmvey @acarbonetto @MitchellGale @matthewryanwells