Improve text area ux and add expression UI #603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]>
Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]>
Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]>
Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
jovancacvetkovic
changed the title
Codecov Report
@@ Coverage Diff @@
## main #603 +/- ##
==========================================
- Coverage 31.48% 31.05% -0.44%
==========================================
Files 138 139 +1
Lines 4335 4415 +80
Branches 771 784 +13
==========================================
+ Hits 1365 1371 +6
- Misses 2832 2905 +73
- Partials 138 139 +1 |
…ct#602 Signed-off-by: Jovan Cvetkovic <[email protected]>
…ct#602 Signed-off-by: Jovan Cvetkovic <[email protected]>
…-analytics-dashboards-plugin into Improve_list_text_area_UX # Conflicts: # cypress/integration/2_rules.spec.js # public/app.scss # public/pages/Rules/components/RuleEditor/DetectionVisualEditor.tsx
Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic
pushed a commit
to jovancacvetkovic/security-analytics-dashboards-plugin
that referenced
this pull request
Jun 2, 2023
Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic
pushed a commit
to jovancacvetkovic/security-analytics-dashboards-plugin
that referenced
this pull request
Jun 2, 2023
Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic
pushed a commit
to jovancacvetkovic/security-analytics-dashboards-plugin
that referenced
this pull request
Jun 2, 2023
Signed-off-by: Jovan Cvetkovic <[email protected]>
|
Merged with #611 |
AWSHurneyt
pushed a commit
that referenced
this pull request
Jun 21, 2023
* [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * Change the order of the sections in the "Create detection rule" page #586 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * bugfix for tags validation Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * Improve text area ux and add expression UI #603 Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Change the order of the sections #622 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 21, 2023
* [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * Change the order of the sections in the "Create detection rule" page #586 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * bugfix for tags validation Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * Improve text area ux and add expression UI #603 Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Change the order of the sections #622 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit e3c103e)
amsiglan
pushed a commit
that referenced
this pull request
Jul 12, 2023
* [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * Change the order of the sections in the "Create detection rule" page #586 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * bugfix for tags validation Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * Improve text area ux and add expression UI #603 Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Change the order of the sections #622 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit e3c103e) Co-authored-by: Jovan Cvetkovic <[email protected]>
opensearch-trigger-bot bot
added a commit
that referenced
this pull request
Jul 12, 2023
* [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * Change the order of the sections in the "Create detection rule" page #586 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * bugfix for tags validation Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * Improve text area ux and add expression UI #603 Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Change the order of the sections #622 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit e3c103e) Co-authored-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit c2ff25f)
amsiglan
pushed a commit
that referenced
this pull request
Jul 12, 2023
* [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * Change the order of the sections in the "Create detection rule" page #586 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * bugfix for tags validation Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * Improve text area ux and add expression UI #603 Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Change the order of the sections #622 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit e3c103e) Co-authored-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit c2ff25f) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…-project#634) (opensearch-project#644) * [FEATURE] Improve "list" text area UX opensearch-project#589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX opensearch-project#589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX opensearch-project#589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX opensearch-project#589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * Change the order of the sections in the "Create detection rule" page opensearch-project#586 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * bugfix for tags validation Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page opensearch-project#586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications opensearch-project#601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission opensearch-project#613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page opensearch-project#586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications opensearch-project#601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission opensearch-project#613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor opensearch-project#602 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor opensearch-project#602 Signed-off-by: Jovan Cvetkovic <[email protected]> * Improve text area ux and add expression UI opensearch-project#603 Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Change the order of the sections opensearch-project#622 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit e3c103e) Co-authored-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit c2ff25f) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves textarea resizing on user input.
Replaces code editor for rule conditions with the expression editor.
Issues Resolved
Resolves #589
Resolves #602
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.