-
Notifications
You must be signed in to change notification settings - Fork 48
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Change the order of the sections (#622)
* [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * Change the order of the sections in the "Create detection rule" page #586 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * bugfix for tags validation Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * Improve text area ux and add expression UI #603 Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Change the order of the sections #622 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit e3c103e)
- Loading branch information
1 parent
451861e
commit 0f21245
Showing
47 changed files
with
10,447 additions
and
937 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
public/pages/Rules/components/DeleteModal/DeleteRuleModal.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| /* | ||
| * Copyright OpenSearch Contributors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import { render } from '@testing-library/react'; | ||
| import DeleteRuleModalMock from '../../../../../test/mocks/Rules/components/DeleteModal/DeleteRuleModal.mock'; | ||
| import { DeleteRuleModal } from './DeleteRuleModal'; | ||
|
|
||
| describe('<DeleteModal /> spec', () => { | ||
| it('renders the component', () => { | ||
| const tree = render(<DeleteRuleModal {...DeleteRuleModalMock} />); | ||
| expect(tree).toMatchSnapshot(); | ||
| }); | ||
| }); |
File renamed without changes.
168 changes: 168 additions & 0 deletions
168
public/pages/Rules/components/DeleteModal/__snapshots__/DeleteRuleModal.test.tsx.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,168 @@ | ||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
|
||
| exports[`<DeleteModal /> spec renders the component 1`] = ` | ||
| Object { | ||
| "asFragment": [Function], | ||
| "baseElement": <body | ||
| class="euiBody-hasOverlayMask" | ||
| > | ||
| <div | ||
| aria-hidden="true" | ||
| data-aria-hidden="true" | ||
| /> | ||
| <div | ||
| class="euiOverlayMask euiOverlayMask--aboveHeader" | ||
| > | ||
| <div | ||
| aria-hidden="true" | ||
| data-aria-hidden="true" | ||
| data-focus-guard="true" | ||
| style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;" | ||
| tabindex="0" | ||
| /> | ||
| <div | ||
| data-focus-lock-disabled="false" | ||
| > | ||
| <div | ||
| class="euiModal euiModal--maxWidth-default euiModal--confirmation" | ||
| tabindex="0" | ||
| > | ||
| <button | ||
| aria-label="Closes this modal window" | ||
| class="euiButtonIcon euiButtonIcon--text euiButtonIcon--empty euiButtonIcon--xSmall euiModal__closeIcon" | ||
| type="button" | ||
| > | ||
| EuiIconMock | ||
| </button> | ||
| <div | ||
| class="euiModal__flex" | ||
| > | ||
| <div | ||
| class="euiModalHeader" | ||
| > | ||
| <div | ||
| class="euiModalHeader__title" | ||
| data-test-subj="confirmModalTitleText" | ||
| > | ||
| Delete Delete rule? | ||
| </div> | ||
| </div> | ||
| <div | ||
| class="euiModalBody" | ||
| > | ||
| <div | ||
| class="euiModalBody__overflow" | ||
| > | ||
| <div | ||
| class="euiText euiText--medium" | ||
| data-test-subj="confirmModalBodyText" | ||
| > | ||
| <p> | ||
| Delete the rule permanently? This action cannot be undone. | ||
| </p> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| <div | ||
| class="euiModalFooter" | ||
| > | ||
| <button | ||
| class="euiButtonEmpty euiButtonEmpty--primary" | ||
| data-test-subj="confirmModalCancelButton" | ||
| type="button" | ||
| > | ||
| <span | ||
| class="euiButtonContent euiButtonEmpty__content" | ||
| > | ||
| <span | ||
| class="euiButtonEmpty__text" | ||
| > | ||
| Cancel | ||
| </span> | ||
| </span> | ||
| </button> | ||
| <button | ||
| class="euiButton euiButton--danger euiButton--fill" | ||
| data-test-subj="confirmModalConfirmButton" | ||
| type="button" | ||
| > | ||
| <span | ||
| class="euiButtonContent euiButton__content" | ||
| > | ||
| <span | ||
| class="euiButton__text" | ||
| > | ||
| Delete | ||
| </span> | ||
| </span> | ||
| </button> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| <div | ||
| aria-hidden="true" | ||
| data-aria-hidden="true" | ||
| data-focus-guard="true" | ||
| style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;" | ||
| tabindex="0" | ||
| /> | ||
| </div> | ||
| </body>, | ||
| "container": <div | ||
| aria-hidden="true" | ||
| data-aria-hidden="true" | ||
| />, | ||
| "debug": [Function], | ||
| "findAllByAltText": [Function], | ||
| "findAllByDisplayValue": [Function], | ||
| "findAllByLabelText": [Function], | ||
| "findAllByPlaceholderText": [Function], | ||
| "findAllByRole": [Function], | ||
| "findAllByTestId": [Function], | ||
| "findAllByText": [Function], | ||
| "findAllByTitle": [Function], | ||
| "findByAltText": [Function], | ||
| "findByDisplayValue": [Function], | ||
| "findByLabelText": [Function], | ||
| "findByPlaceholderText": [Function], | ||
| "findByRole": [Function], | ||
| "findByTestId": [Function], | ||
| "findByText": [Function], | ||
| "findByTitle": [Function], | ||
| "getAllByAltText": [Function], | ||
| "getAllByDisplayValue": [Function], | ||
| "getAllByLabelText": [Function], | ||
| "getAllByPlaceholderText": [Function], | ||
| "getAllByRole": [Function], | ||
| "getAllByTestId": [Function], | ||
| "getAllByText": [Function], | ||
| "getAllByTitle": [Function], | ||
| "getByAltText": [Function], | ||
| "getByDisplayValue": [Function], | ||
| "getByLabelText": [Function], | ||
| "getByPlaceholderText": [Function], | ||
| "getByRole": [Function], | ||
| "getByTestId": [Function], | ||
| "getByText": [Function], | ||
| "getByTitle": [Function], | ||
| "queryAllByAltText": [Function], | ||
| "queryAllByDisplayValue": [Function], | ||
| "queryAllByLabelText": [Function], | ||
| "queryAllByPlaceholderText": [Function], | ||
| "queryAllByRole": [Function], | ||
| "queryAllByTestId": [Function], | ||
| "queryAllByText": [Function], | ||
| "queryAllByTitle": [Function], | ||
| "queryByAltText": [Function], | ||
| "queryByDisplayValue": [Function], | ||
| "queryByLabelText": [Function], | ||
| "queryByPlaceholderText": [Function], | ||
| "queryByRole": [Function], | ||
| "queryByTestId": [Function], | ||
| "queryByText": [Function], | ||
| "queryByTitle": [Function], | ||
| "rerender": [Function], | ||
| "unmount": [Function], | ||
| } | ||
| `; |
16 changes: 16 additions & 0 deletions
16
public/pages/Rules/components/RuleEditor/DetectionVisualEditor.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| /* | ||
| * Copyright OpenSearch Contributors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import { render } from '@testing-library/react'; | ||
| import { DetectionVisualEditor } from './DetectionVisualEditor'; | ||
| import DetectionVisualEditorMock from '../../../../../test/mocks/Rules/components/RuleEditor/DetectionVisualEditor.mock'; | ||
|
|
||
| describe('<SelectionExpField /> spec', () => { | ||
| it('renders the component', () => { | ||
| const tree = render(<DetectionVisualEditor {...DetectionVisualEditorMock} />); | ||
| expect(tree).toMatchSnapshot(); | ||
| }); | ||
| }); |
Oops, something went wrong.