[FEATURE] Improve the Create detection rules - selection panel fields error notifications #601
Labels
enhancement
New feature or request
Comments
jovancacvetkovic
pushed a commit
to jovancacvetkovic/security-analytics-dashboards-plugin
that referenced
this issue
Jun 1, 2023
…ule" page opensearch-project#586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications opensearch-project#601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission opensearch-project#613 Signed-off-by: Jovan Cvetkovic <[email protected]>
1 task
jovancacvetkovic
pushed a commit
to jovancacvetkovic/security-analytics-dashboards-plugin
that referenced
this issue
Jun 1, 2023
…ule" page opensearch-project#586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications opensearch-project#601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission opensearch-project#613 Signed-off-by: Jovan Cvetkovic <[email protected]>
1 task
AWSHurneyt
pushed a commit
that referenced
this issue
Jun 21, 2023
* [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * Change the order of the sections in the "Create detection rule" page #586 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * bugfix for tags validation Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * Improve text area ux and add expression UI #603 Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Change the order of the sections #622 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this issue
Jun 21, 2023
* [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * Change the order of the sections in the "Create detection rule" page #586 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * bugfix for tags validation Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * Improve text area ux and add expression UI #603 Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Change the order of the sections #622 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit e3c103e)
amsiglan
pushed a commit
that referenced
this issue
Jul 12, 2023
* [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * Change the order of the sections in the "Create detection rule" page #586 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * bugfix for tags validation Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * Improve text area ux and add expression UI #603 Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Change the order of the sections #622 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit e3c103e) Co-authored-by: Jovan Cvetkovic <[email protected]>
opensearch-trigger-bot bot
added a commit
that referenced
this issue
Jul 12, 2023
* [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * Change the order of the sections in the "Create detection rule" page #586 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * bugfix for tags validation Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * Improve text area ux and add expression UI #603 Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Change the order of the sections #622 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit e3c103e) Co-authored-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit c2ff25f)
amsiglan
pushed a commit
that referenced
this issue
Jul 12, 2023
* [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX #589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * Change the order of the sections in the "Create detection rule" page #586 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * bugfix for tags validation Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page #586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications #601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor #602 Signed-off-by: Jovan Cvetkovic <[email protected]> * Improve text area ux and add expression UI #603 Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Change the order of the sections #622 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit e3c103e) Co-authored-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit c2ff25f) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this issue
Oct 12, 2023
…-project#634) (opensearch-project#644) * [FEATURE] Improve "list" text area UX opensearch-project#589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX opensearch-project#589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX opensearch-project#589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Improve "list" text area UX opensearch-project#589 Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]> * Change the order of the sections in the "Create detection rule" page opensearch-project#586 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> * bugfix for tags validation Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page opensearch-project#586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications opensearch-project#601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission opensearch-project#613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Change the order of the sections in the "Create detection rule" page opensearch-project#586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications opensearch-project#601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission opensearch-project#613 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor opensearch-project#602 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Replace code editor with expression editor opensearch-project#602 Signed-off-by: Jovan Cvetkovic <[email protected]> * Improve text area ux and add expression UI opensearch-project#603 Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Cypress cases for detectors and rules, validate forms and fields Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Change the order of the sections opensearch-project#622 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit e3c103e) Co-authored-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit c2ff25f) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem?
Currently, there are no notifications indicating that the selection map field is missing if the user clicks on submit button.
The only message popup toaster "Some fields are invalid. Fix all highlighted error(s) before continuing".
What solution would you like?
Add more visible notifications so that users can see what fields are missing from the form.
Do you have any additional context?
The "Key" field should be marked as invalid after the user clicks on submit button.
The message here doesn't state where the error is.
The text was updated successfully, but these errors were encountered: