Change the order of the sections #611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]>
Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]>
Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]>
Use expression builder instead of code editor Signed-off-by: Jovan Cvetkovic <[email protected]>
…pensearch-project#586 Signed-off-by: Jovan Cvetkovic <[email protected]>
…-analytics-dashboards-plugin into Change_the_order_of_the_sections # Conflicts: # public/app.scss # public/pages/Rules/components/RuleEditor/RuleEditorForm.scss # public/pages/Rules/components/RuleEditor/components/YamlRuleEditorComponent/RuleTagsComboBox.tsx
Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
Codecov Report
@@ Coverage Diff @@
## main #611 +/- ##
==========================================
- Coverage 31.48% 31.33% -0.16%
==========================================
Files 138 139 +1
Lines 4335 4446 +111
Branches 771 743 -28
==========================================
+ Hits 1365 1393 +28
- Misses 2832 2912 +80
- Partials 138 141 +3 |
Signed-off-by: Jovan Cvetkovic <[email protected]>
…ule" page opensearch-project#586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications opensearch-project#601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission opensearch-project#613 Signed-off-by: Jovan Cvetkovic <[email protected]>
…ule" page opensearch-project#586 [FEATURE] Improve the Create detection rules - selection panel fields error notifications opensearch-project#601 [FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission opensearch-project#613 Signed-off-by: Jovan Cvetkovic <[email protected]>
…ct#602 Signed-off-by: Jovan Cvetkovic <[email protected]>
…ct#602 Signed-off-by: Jovan Cvetkovic <[email protected]>
…-analytics-dashboards-plugin into Improve_list_text_area_UX # Conflicts: # cypress/integration/2_rules.spec.js # public/app.scss # public/pages/Rules/components/RuleEditor/DetectionVisualEditor.tsx
Signed-off-by: Jovan Cvetkovic <[email protected]>
…acvetkovic/security-analytics-dashboards-plugin into Change_the_order_of_the_sections # Conflicts: # public/pages/Rules/components/RuleEditor/DetectionVisualEditor.tsx # public/pages/Rules/components/RuleEditor/RuleEditorForm.tsx
…cacvetkovic/security-analytics-dashboards-plugin into Change_the_order_of_the_sections # Conflicts: # public/pages/Rules/components/RuleEditor/components/YamlRuleEditorComponent/RuleTagsComboBox.tsx
Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Jovan Cvetkovic <[email protected]>
This was referenced Jun 7, 2023
Signed-off-by: Jovan Cvetkovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sort and reorder the Creation detection rule UX components
Issues Resolved
Resolves #586
Resolves #601
Resolves #613
Resolves #589
Resolves #602
Screenshots
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.