Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Improve "list" text area UX #589

Closed
jovancacvetkovic opened this issue May 17, 2023 · 0 comments · Fixed by #622
Closed

[FEATURE] Improve "list" text area UX #589

jovancacvetkovic opened this issue May 17, 2023 · 0 comments · Fixed by #622
Labels
enhancement New feature or request

Comments

@jovancacvetkovic
Copy link

jovancacvetkovic commented May 17, 2023

Is your feature request related to a problem?
Improve "text" list component UX for the "Create detection rule" page:

  • Increase the size of the text area for lists. Ideally, it should increase as it is being filled up to 2-3 times taller (not to the full list length)
  • Add "clear list" button (the button is disabled until textarea is not empty)
    - the list is typed in manually
    - the list is uploaded from a file
  • Validate list syntax onBlur or prepend each list item with '-' on submission
  • If the "list" text area is not empty, and the user clicks "Upload file", show a warning in the modal of the content to be replaced

Do you have any additional context?
image
image
image
image

@jovancacvetkovic jovancacvetkovic added enhancement New feature or request untriaged labels May 17, 2023
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue May 29, 2023
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue May 29, 2023
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue May 30, 2023
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue May 30, 2023
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt pushed a commit that referenced this issue Jun 21, 2023
* [FEATURE] Improve "list" text area UX #589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Improve "list" text area UX #589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Improve "list" text area UX #589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Improve "list" text area UX #589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Change the order of the sections in the "Create detection rule" page #586

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* bugfix for tags validation

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Change the order of the sections in the "Create detection rule" page #586
[FEATURE] Improve the Create detection rules - selection panel fields error notifications #601
[FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Change the order of the sections in the "Create detection rule" page #586
[FEATURE] Improve the Create detection rules - selection panel fields error notifications #601
[FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Replace code editor with expression editor #602

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Replace code editor with expression editor #602

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Improve text area ux and add expression UI #603

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review Change the order of the sections #622

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jun 21, 2023
* [FEATURE] Improve "list" text area UX #589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Improve "list" text area UX #589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Improve "list" text area UX #589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Improve "list" text area UX #589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Change the order of the sections in the "Create detection rule" page #586

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* bugfix for tags validation

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Change the order of the sections in the "Create detection rule" page #586
[FEATURE] Improve the Create detection rules - selection panel fields error notifications #601
[FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Change the order of the sections in the "Create detection rule" page #586
[FEATURE] Improve the Create detection rules - selection panel fields error notifications #601
[FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Replace code editor with expression editor #602

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Replace code editor with expression editor #602

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Improve text area ux and add expression UI #603

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review Change the order of the sections #622

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit e3c103e)
amsiglan pushed a commit that referenced this issue Jul 12, 2023
* [FEATURE] Improve "list" text area UX #589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Improve "list" text area UX #589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Improve "list" text area UX #589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Improve "list" text area UX #589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Change the order of the sections in the "Create detection rule" page #586

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* bugfix for tags validation

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Change the order of the sections in the "Create detection rule" page #586
[FEATURE] Improve the Create detection rules - selection panel fields error notifications #601
[FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Change the order of the sections in the "Create detection rule" page #586
[FEATURE] Improve the Create detection rules - selection panel fields error notifications #601
[FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Replace code editor with expression editor #602

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Replace code editor with expression editor #602

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Improve text area ux and add expression UI #603

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review Change the order of the sections #622

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit e3c103e)

Co-authored-by: Jovan Cvetkovic <[email protected]>
opensearch-trigger-bot bot added a commit that referenced this issue Jul 12, 2023
* [FEATURE] Improve "list" text area UX #589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Improve "list" text area UX #589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Improve "list" text area UX #589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Improve "list" text area UX #589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Change the order of the sections in the "Create detection rule" page #586

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* bugfix for tags validation

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Change the order of the sections in the "Create detection rule" page #586
[FEATURE] Improve the Create detection rules - selection panel fields error notifications #601
[FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Change the order of the sections in the "Create detection rule" page #586
[FEATURE] Improve the Create detection rules - selection panel fields error notifications #601
[FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Replace code editor with expression editor #602

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Replace code editor with expression editor #602

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Improve text area ux and add expression UI #603

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review Change the order of the sections #622

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit e3c103e)

Co-authored-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit c2ff25f)
amsiglan pushed a commit that referenced this issue Jul 12, 2023
* [FEATURE] Improve "list" text area UX #589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Improve "list" text area UX #589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Improve "list" text area UX #589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Improve "list" text area UX #589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Change the order of the sections in the "Create detection rule" page #586

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* bugfix for tags validation

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Change the order of the sections in the "Create detection rule" page #586
[FEATURE] Improve the Create detection rules - selection panel fields error notifications #601
[FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Change the order of the sections in the "Create detection rule" page #586
[FEATURE] Improve the Create detection rules - selection panel fields error notifications #601
[FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission #613

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Replace code editor with expression editor #602

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Replace code editor with expression editor #602

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Improve text area ux and add expression UI #603

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review Change the order of the sections #622

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit e3c103e)

Co-authored-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit c2ff25f)

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Oct 12, 2023
…-project#634) (opensearch-project#644)

* [FEATURE] Improve "list" text area UX opensearch-project#589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Improve "list" text area UX opensearch-project#589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Improve "list" text area UX opensearch-project#589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Improve "list" text area UX opensearch-project#589
Use expression builder instead of code editor

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Change the order of the sections in the "Create detection rule" page opensearch-project#586

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* bugfix for tags validation

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Change the order of the sections in the "Create detection rule" page opensearch-project#586
[FEATURE] Improve the Create detection rules - selection panel fields error notifications opensearch-project#601
[FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission opensearch-project#613

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Change the order of the sections in the "Create detection rule" page opensearch-project#586
[FEATURE] Improve the Create detection rules - selection panel fields error notifications opensearch-project#601
[FEATURE] Improve the Create detection rules - selection panel condition field is not marked as invalid after submission opensearch-project#613

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Replace code editor with expression editor opensearch-project#602

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Replace code editor with expression editor opensearch-project#602

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Improve text area ux and add expression UI opensearch-project#603

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Cypress cases for detectors and rules, validate forms and fields

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review Change the order of the sections opensearch-project#622

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit e3c103e)

Co-authored-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit c2ff25f)

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment