Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3 #422

Closed
wants to merge 33 commits into from
Closed

1.3 #422

wants to merge 33 commits into from

Conversation

charliezhangaws
Copy link
Contributor

Issue #, if available:
#329
Description of changes:
There are a couple tests that are flaky and fail in the SecureMonitorRestApiIT test class
CheckList:
[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

AWSHurneyt and others added 30 commits June 30, 2021 23:06
…ject#133)

* Added release notes for OpenSearch 1.0.0.0. (opensearch-project#123) (opensearch-project#124)

Co-authored-by: AWSHurneyt <[email protected]>

* Add Integtest.sh for OpenSearch integtest setups (opensearch-project#121)

* Add integtest script to the repo

Signed-off-by: Peter Zhu <[email protected]>

* Add Alerting specific security param for integTest

Signed-off-by: Peter Zhu <[email protected]>

* Remove default assignee (opensearch-project#127)

Signed-off-by: Ashish Agrawal <[email protected]>

* Removing All Usages of Action Get Method Calls and adding the listeners (opensearch-project#130)

Signed-off-by: Aditya Jindal <[email protected]>

* Fix snapshot build and increment to 1.1.0. (opensearch-project#142)

Signed-off-by: dblock <[email protected]>

* Refactor MonitorRunner (opensearch-project#143)

Signed-off-by: Mohammad Qureshi <[email protected]>

* Update Bucket-Level Alerting RFC (opensearch-project#145)

Signed-off-by: Mohammad Qureshi <[email protected]>

* Add BucketSelector pipeline aggregation extension (opensearch-project#144)

Signed-off-by: Mohammad Qureshi <[email protected]>

Co-authored-by: Rishabh Maurya <[email protected]>

* Add AggregationResultBucket (opensearch-project#148)

Signed-off-by: Mohammad Qureshi <[email protected]>

Co-authored-by: Rishabh Maurya <[email protected]>

* Add ActionExecutionPolicy (opensearch-project#149)

* Add ActionExecutionPolicy

Signed-off-by: Mohammad Qureshi <[email protected]>

* Throw exception if there is an invalid field in PER_ALERT config when parsing

Signed-off-by: Mohammad Qureshi <[email protected]>

* Don't allow throttle to be configured for PerExecutionActionScope at the data class level since it is not supported yet

Signed-off-by: Mohammad Qureshi <[email protected]>

* Refactor Monitor and Trigger to split into Query-Level and Bucket-Lev… (opensearch-project#150)

* Refactor Monitor and Trigger to split into Query-Level and Bucket-Level Monitors

Signed-off-by: Mohammad Qureshi <[email protected]>

* Require condition to not be null when parsing Bucket-Level Trigger

Signed-off-by: Mohammad Qureshi <[email protected]>

* Update InputService for Bucket-Level Alerting (opensearch-project#152)

Signed-off-by: Mohammad Qureshi <[email protected]>

Co-authored-by: Rishabh Maurya <[email protected]>

* Update TriggerService for Bucket-Level Alerting (opensearch-project#153)

* Update TriggerService for Bucket-Level Alerting

Signed-off-by: Mohammad Qureshi <[email protected]>

* Remove client from TriggerService

Signed-off-by: Mohammad Qureshi <[email protected]>

* Update AlertService for Bucket-Level Alerting (opensearch-project#154)

* Update AlertService for Bucket-Level Alerting

Signed-off-by: Mohammad Qureshi <[email protected]>

* Move Alert search size for Bucket-Level Monitors to a const

Signed-off-by: Mohammad Qureshi <[email protected]>

* Add worksheets to help with testing (opensearch-project#151)

Signed-off-by: Mohammad Qureshi <[email protected]>

* Update MonitorRunner for Bucket-Level Alerting (opensearch-project#155)

* Update MonitorRunner for Bucket-Level Alerting

Signed-off-by: Mohammad Qureshi <[email protected]>

* Update regressed comment in MonitorRunnerIT

Signed-off-by: Mohammad Qureshi <[email protected]>

* Add TODO to break down runBucketLevelMonitor method in MonitorRunner

Signed-off-by: Mohammad Qureshi <[email protected]>

* Fix ktlint formatting issues (opensearch-project#156)

Signed-off-by: Mohammad Qureshi <[email protected]>

* Execute Actions on runTrigger exceptions for Bucket-Level Monitor (opensearch-project#157)

Signed-off-by: Mohammad Qureshi <[email protected]>

* Skip execution of Actions on ACKNOWLEDGED Alerts for Bucket-Level Monitors (opensearch-project#158)

Signed-off-by: Mohammad Qureshi <[email protected]>

* Return first page of input results in MonitorRunResult for Bucket-Level Monitor (opensearch-project#159)

Signed-off-by: Mohammad Qureshi <[email protected]>

* Add setting to limit per alert action executions and don't save Alerts for test Bucket-Level Monitors (opensearch-project#161)

Signed-off-by: Mohammad Qureshi <[email protected]>

* Fix bug in paginating multiple bucket paths for Bucket-Level Monitor (opensearch-project#163)

* Fix bug in paginating multiple bucket paths for Bucket-Level Monitor

Signed-off-by: Mohammad Qureshi <[email protected]>

* Change trigger after key conditionals to when statement

Signed-off-by: Mohammad Qureshi <[email protected]>

* Various bug fixes pertaining to throttling on PER_ALERT, saving COMPLETED Alerts and rewriting input query for Bucket-Level Monitors (opensearch-project#164)

Signed-off-by: Mohammad Qureshi <[email protected]>

* Return only monitors for /monitors/_search. (opensearch-project#162)

* Return only monitors for /monitors/_search.

* Added missing imports

* Added additional check to the unit test

* Resolve default for ActionExecutionPolicy at runtime (opensearch-project#165)

Signed-off-by: Mohammad Qureshi <[email protected]>

Co-authored-by: AWSHurneyt <[email protected]>
Co-authored-by: Peter Zhu <[email protected]>
Co-authored-by: Ashish Agrawal <[email protected]>
Co-authored-by: Daniel Doubrovkine (dB.) <[email protected]>
Co-authored-by: Mohammad Qureshi <[email protected]>
Co-authored-by: Rishabh Maurya <[email protected]>
Co-authored-by: Sriram <[email protected]>
* Remove default integtest.sh. (opensearch-project#181)

Signed-off-by: dblock <[email protected]>

* Add valid search filters.

* Added this fix to release notes

Co-authored-by: Daniel Doubrovkine (dB.) <[email protected]>
…ledging more than 10 alerts at once. Signed-off-by: Thomas Hurney <[email protected]> (opensearch-project#208)
* Update copyright notice (opensearch-project#222)

Signed-off-by: Mohammad Qureshi <[email protected]>

* Admin Users must be able to access all monitors opensearch-project#139 (opensearch-project#220)

* Admin Users must be able to access all monitors opensearch-project#139

* Refactored

Co-authored-by: Mohammad Qureshi <[email protected]>
Co-authored-by: Sriram <[email protected]>
* Updates alerting version to 1.2 (opensearch-project#192)

* Updates alerting version to 1.2

* Adds snapshot repo to the repository file

Signed-off-by: Clay Downs <[email protected]>

* Update build to use public Maven repo (opensearch-project#184)

Signed-off-by: Abbas Hussain <[email protected]>

* Publish notification JARs checksums. (opensearch-project#196)

* Publish notification JARs checksums.

Signed-off-by: dblock <[email protected]>

* Remove sonatype staging.

Signed-off-by: dblock <[email protected]>

* Updates testCompile mockito version to match OpenSearch changes (opensearch-project#204)

Signed-off-by: Clay Downs <[email protected]>

* Update maven publication to include cksums. (opensearch-project#224)

This change adds a task to publish to a local staging repo under build/ that includes cksums.  It also updates build.sh to use this new task and copy the contents of the staging repo to the output directory.
The maven publish plugin will not include these cksums when publishing to maven local but will when published to a separate folder.

Signed-off-by: Marc Handalian <[email protected]>

* Add release notes for 1.2.0.0 release (opensearch-project#225)

* Create opensearch-alerting.release-notes-1.2.0.0.md

Signed-off-by: Annie Lee <[email protected]>

* Update opensearch-alerting.release-notes-1.2.0.0.md

* Update opensearch-alerting.release-notes-1.2.0.0.md

* Add backwards compatibility tests (opensearch-project#199)

* Initial commit for BWC tests

Signed-off-by: Mohammad Qureshi <[email protected]>

* Update bwc test to check Monitor stats and add bwc tests to GitHub Actions

Signed-off-by: Mohammad Qureshi <[email protected]>

* Use current version plugin bundle from build for bwc tests instead of manually uploading

Signed-off-by: Mohammad Qureshi <[email protected]>

* Update mockito-core dependency to 3.12.4 to prevent conflict

Signed-off-by: Mohammad Qureshi <[email protected]>

* Remove disabling security manager flag when running BWC tests

Signed-off-by: Mohammad Qureshi <[email protected]>

Co-authored-by: Clay Downs <[email protected]>
Co-authored-by: Abbas Hussain <[email protected]>
Co-authored-by: Daniel Doubrovkine (dB.) <[email protected]>
Co-authored-by: Marc Handalian <[email protected]>
Co-authored-by: Annie Lee <[email protected]>
Co-authored-by: Mohammad Qureshi <[email protected]>
* Update build.sh to take platform parameter. (opensearch-project#240)

Signed-off-by: Marc Handalian <[email protected]>

* Add a codeowners file (opensearch-project#235)

Signed-off-by: CEHENKLE <[email protected]>

* Update README badge links to refer to OpenSearch Alerting (opensearch-project#244)

Signed-off-by: Mohammad Qureshi <[email protected]>

* Bumps to version 1.3 (opensearch-project#248)

Signed-off-by: Clay Downs <[email protected]>

* Update GitHub Actions to run on all branches (opensearch-project#256)

Signed-off-by: Mohammad Qureshi <[email protected]>

* Update sweep logic to re-schedule unchanged jobs when SWEEPER_ENABLED is toggled (opensearch-project#243)

* Update sweep logic to re-schedule unchanged jobs when SWEEPER_ENABLED is toggled

Signed-off-by: Mohammad Qureshi <[email protected]>

* Update isMonitorScheduled to not use var for returned boolean

Signed-off-by: Mohammad Qureshi <[email protected]>

Co-authored-by: Marc Handalian <[email protected]>
Co-authored-by: CEHENKLE <[email protected]>
Co-authored-by: Mohammad Qureshi <[email protected]>
Co-authored-by: Clay Downs <[email protected]>
…#287)

* Remove runBlocking calls from MonitorRunner (opensearch-project#281)

* Remove runBlocking calls from MonitorRunner

Signed-off-by: Mohammad Qureshi <[email protected]>

* Add security tests with partial user permissions to check user context being correctly applied

Signed-off-by: Mohammad Qureshi <[email protected]>

* Fix ktlint style issues

Signed-off-by: Mohammad Qureshi <[email protected]>

* Add back opendistro prefixed sweeper enabled field to alerting stats response (opensearch-project#283)

* Add back opendistro prefixed sweeper enabled to alerting stats response

Signed-off-by: Mohammad Qureshi <[email protected]>

* Rename stats response field variables used in tests

Signed-off-by: Mohammad Qureshi <[email protected]>
)

* Adding ITs to check for Default Role Permissions

Signed-off-by: Aditya Jindal <[email protected]>
…nsearch-project#303)

Adding New Tests for Email Account Access

Add tests for Monitors and Destinations

Signed-off-by: Aditya Jindal <[email protected]>
…ject#252)

* Remove appending candidate_version to OpenSearch docker tag

Signed-off-by: Mohammad Qureshi <[email protected]>

* Split tests into separate workflows

Signed-off-by: Mohammad Qureshi <[email protected]>

* Fix syntax error in test-workflow

Signed-off-by: Mohammad Qureshi <[email protected]>
* Add 1.2.4.0 release notes

Signed-off-by: Ashish Agrawal <[email protected]>
…ensearch-project#331) (opensearch-project#332) (opensearch-project#333)

* Commented out flaky test in favor of known issue opensearch-project#300 to unblock build process.

Signed-off-by: Saurabh Singh <[email protected]>

* Commenting out another test

Signed-off-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>
* Add 1.2.4.0 release notes (opensearch-project#282)

* Add 1.2.4.0 release notes

Signed-off-by: Ashish Agrawal <[email protected]>

* Commented out flaky test in favor of known issue to unblock build (opensearch-project#331) (opensearch-project#332) (opensearch-project#333)

* Commented out flaky test in favor of known issue opensearch-project#300 to unblock build process.

Signed-off-by: Saurabh Singh <[email protected]>

* Commenting out another test

Signed-off-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>

* Cherry-picking commits for 1.3 release from main to 1.x (opensearch-project#345)

* Added support for JDK 8 and 14. (opensearch-project#335)

* Added support for JDK 8 and 14.

Signed-off-by: AWSHurneyt <[email protected]>

* Added support for JDK 8 and 14.

Signed-off-by: AWSHurneyt <[email protected]>

* Added 1.3 release notes. (opensearch-project#336)

* Added 1.3 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Added 1.3 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Add backport and auto delete workflow (opensearch-project#339)

Signed-off-by: Annie Lee <[email protected]>

* Implemented support for ClusterMetrics monitors (opensearch-project#221) (opensearch-project#342)

* Implemented support for LocalUriInput monitors.

Signed-off-by: AWSHurneyt <[email protected]>

* Refactored feature naming convention from LocalUriInput to ClusterMetricsInput. Added Cluster Metrics as a new monitor type to align with frontend experience.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed ktlint errors.

Signed-off-by: AWSHurneyt <[email protected]>

* Implemented randomClusterMetricsMonitor test helper, and refactored tests accordingly.

Signed-off-by: AWSHurneyt <[email protected]>

* Renamed some assets to align with the new name for this feature.

Signed-off-by: AWSHurneyt <[email protected]>

* Refactored cluster metrics feature to remove support for Cat repositories API.

Signed-off-by: AWSHurneyt <[email protected]>

* Refactored supported JSON payload to return all response fields.

Signed-off-by: AWSHurneyt <[email protected]>

* Refactored nodes stats request object to return all metrics.

Signed-off-by: AWSHurneyt <[email protected]>

* Refactored nodes stats request object to return all metrics.

Signed-off-by: AWSHurneyt <[email protected]>

* Removing unused connectionTimeout and socketTimeout params.

Signed-off-by: AWSHurneyt <[email protected]>

* Added cluster metrics monitor to release notes. (opensearch-project#343)

* Added 1.3 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Added 1.3 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Added cluster metrics monitor to release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated DEVELOPER_GUIDE.md and workflows to reference changes to the supported JDKs. (opensearch-project#338)

* Added support for JDK 8 and 14.

Signed-off-by: AWSHurneyt <[email protected]>

* Added support for JDK 8 and 14.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs.

Signed-off-by: AWSHurneyt <[email protected]>

* Added additional release note.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated workflows to build using JDK 11.

Signed-off-by: AWSHurneyt <[email protected]>

* Removing redundant JDK setup step.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed guide wording.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed guide wording.

Signed-off-by: AWSHurneyt <[email protected]>

* Reverted bwc workflow JDK.

Signed-off-by: AWSHurneyt <[email protected]>

Co-authored-by: Annie Lee <[email protected]>

Co-authored-by: Ashish Agrawal <[email protected]>
Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>
Co-authored-by: Annie Lee <[email protected]>
gaiksaya and others added 3 commits March 28, 2022 11:57
* Incremented version to 1.3.2.

Signed-off-by: Sayali Rohidas Gaikawad <[email protected]>

* Remove hardcoded value

Signed-off-by: Sayali Gaikawad <[email protected]>
@charliezhangaws charliezhangaws requested a review from a team April 23, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.