Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete gradle.properties #262

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 18, 2021

This file is misleading and is not used. The version of the plugin is derived from -Dopensearch.version. That mechanism prevents a conflict between the version in gradle.properties and the OpenSearch version passed in.

CheckList:
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock requested a review from a team December 18, 2021 13:58
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2021

Codecov Report

Merging #262 (a0b1d22) into main (f92dec0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #262   +/-   ##
=========================================
  Coverage     78.63%   78.63%           
+ Complexity      218      217    -1     
=========================================
  Files           173      173           
  Lines          6968     6968           
  Branches        915      915           
=========================================
  Hits           5479     5479           
- Misses         1002     1005    +3     
+ Partials        487      484    -3     
Impacted Files Coverage Δ
...ing/destination/client/DestinationEmailClient.java 72.50% <0.00%> (-5.00%) ⬇️
...ing/model/destination/DestinationContextFactory.kt 66.66% <0.00%> (ø)
...ain/kotlin/org/opensearch/alerting/AlertService.kt 79.02% <0.00%> (+0.48%) ⬆️
...lerting/transport/TransportExecuteMonitorAction.kt 73.33% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f92dec0...a0b1d22. Read the comment docs.

@dblock dblock merged commit 0709aaf into opensearch-project:main Dec 21, 2021
@dblock dblock deleted the delete-properties branch December 21, 2021 12:47
lezzago added a commit that referenced this pull request Jan 10, 2022
* Update license headers (#239)

Signed-off-by: Annie Lee <[email protected]>

* Delete unused properties file. (#262)

Signed-off-by: dblock <[email protected]>

* Update cron-utils (#266)

* Update cron-utils

Signed-off-by: Ashish Agrawal <[email protected]>

* Add last run context to Monitor data model

Signed-off-by: Ashish Agrawal <[email protected]>

Co-authored-by: Annie Lee <[email protected]>
Co-authored-by: Daniel Doubrovkine (dB.) <[email protected]>
lezzago pushed a commit to lezzago/alerting-opensearch that referenced this pull request Mar 9, 2022
lezzago pushed a commit to lezzago/alerting-opensearch that referenced this pull request Mar 9, 2022
lezzago pushed a commit to lezzago/alerting-opensearch that referenced this pull request Mar 9, 2022
lezzago pushed a commit that referenced this pull request Mar 9, 2022
Signed-off-by: Daniel Doubrovkine (dB.) <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/OpenSearch-Alerting that referenced this pull request Mar 30, 2022
Signed-off-by: Daniel Doubrovkine (dB.) <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
lezzago added a commit to lezzago/alerting-opensearch that referenced this pull request Apr 10, 2022
* Update license headers (opensearch-project#239)

Signed-off-by: Annie Lee <[email protected]>

* Delete unused properties file. (opensearch-project#262)

Signed-off-by: dblock <[email protected]>

* Update cron-utils (opensearch-project#266)

* Update cron-utils

Signed-off-by: Ashish Agrawal <[email protected]>

* Add last run context to Monitor data model

Signed-off-by: Ashish Agrawal <[email protected]>

Co-authored-by: Annie Lee <[email protected]>
Co-authored-by: Daniel Doubrovkine (dB.) <[email protected]>
getsaurabh02 added a commit that referenced this pull request Apr 12, 2022
* Document level alerting dev (#272)

* Update license headers (#239)

Signed-off-by: Annie Lee <[email protected]>

* Delete unused properties file. (#262)

Signed-off-by: dblock <[email protected]>

* Update cron-utils (#266)

* Update cron-utils

Signed-off-by: Ashish Agrawal <[email protected]>

* Add last run context to Monitor data model

Signed-off-by: Ashish Agrawal <[email protected]>

Co-authored-by: Annie Lee <[email protected]>
Co-authored-by: Daniel Doubrovkine (dB.) <[email protected]>

* add Update Monitor function

Signed-off-by: Ashish Agrawal <[email protected]>

* fix integ test

Signed-off-by: Ashish Agrawal <[email protected]>

* Implemented draft of Finding data model, a new Input type, and some basic unit tests. (#260)

* Implemented draft of Finding data model, and some basic unit tests for it.

Signed-off-by: AWSHurneyt <[email protected]>

* POC for doc-level-alerting (#277)

Signed-off-by: Sriram <[email protected]>

* Add connection to triggers for doc level alerting (#316)

Signed-off-by: Ashish Agrawal <[email protected]>

* CRUD APIs integration Tests and validation"conflict resolved" (#362)

Signed-off-by: charliezhangaws <[email protected]>

* Seggregate monitor runner logic for separation of concerns (#363)

* Refactor monitor runner logic for separation of concerns and better testability.

Signed-off-by: Saurabh Singh <[email protected]>

* Add action and alert flow and findings schema and additional fixes (#381)

Signed-off-by: Ashish Agrawal <[email protected]>

* Finding Search API (#385)

* Findings search API based on Annie's work

Signed-off-by: Annie Lee <[email protected]>

* Fix Search API and add IT tests

Signed-off-by: Ashish Agrawal <[email protected]>

Co-authored-by: Annie Lee <[email protected]>

* Fix integ tests and minor issues from doc level changes

Signed-off-by: Ashish Agrawal <[email protected]>

Co-authored-by: Annie Lee <[email protected]>
Co-authored-by: Daniel Doubrovkine (dB.) <[email protected]>
Co-authored-by: AWSHurneyt <[email protected]>
Co-authored-by: Sriram <[email protected]>
Co-authored-by: charliezhangaws <[email protected]>
Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Annie Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants