Updated DEVELOPER_GUIDE.md and workflows to reference changes to the supported JDKs. #338

AWSHurneyt · 2022-03-10T19:44:12Z

Issue #, if available:
#242

Description of changes:

Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs based on this doc.
Updated workflows to build using JDK 11.

CheckList:
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: AWSHurneyt <[email protected]>

codecov-commenter · 2022-03-10T19:52:54Z

Codecov Report

Merging #338 (8a3d494) into main (944d1fa) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #338      +/-   ##
============================================
- Coverage     78.50%   78.26%   -0.25%     
- Complexity      214      264      +50     
============================================
  Files           173      176       +3     
  Lines          6975     7223     +248     
  Branches        916      960      +44     
============================================
+ Hits           5476     5653     +177     
- Misses         1010     1070      +60     
- Partials        489      500      +11

Impacted Files	Coverage Δ
...in/kotlin/org/opensearch/alerting/model/Monitor.kt	`88.67% <0.00%> (-0.29%)`	⬇️
...nsearch/alerting/core/model/ClusterMetricsInput.kt	`95.30% <0.00%> (ø)`
...erting/settings/SupportedClusterMetricsSettings.kt	`19.51% <0.00%> (ø)`
.../util/SupportedClusterMetricsSettingsExtensions.kt	`35.41% <0.00%> (ø)`
...n/kotlin/org/opensearch/alerting/AlertingPlugin.kt	`94.73% <0.00%> (+0.03%)`	⬆️
.../alerting/transport/TransportIndexMonitorAction.kt	`59.52% <0.00%> (+0.47%)`	⬆️
...ain/kotlin/org/opensearch/alerting/InputService.kt	`88.57% <0.00%> (+0.69%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 944d1fa...8a3d494. Read the comment docs.

Signed-off-by: AWSHurneyt <[email protected]>

DEVELOPER_GUIDE.md

Signed-off-by: AWSHurneyt <[email protected]>

DEVELOPER_GUIDE.md

Signed-off-by: AWSHurneyt <[email protected]>

AWSHurneyt · 2022-03-10T23:56:36Z

Successfully ran ./gradlew build locally as well.

Signed-off-by: AWSHurneyt <[email protected]>

…supported JDKs. (opensearch-project#338) * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <[email protected]> * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <[email protected]> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <[email protected]> * Added additional release note. Signed-off-by: AWSHurneyt <[email protected]> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <[email protected]> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <[email protected]> * Updated workflows to build using JDK 11. Signed-off-by: AWSHurneyt <[email protected]> * Removing redundant JDK setup step. Signed-off-by: AWSHurneyt <[email protected]> * Fixed guide wording. Signed-off-by: AWSHurneyt <[email protected]> * Fixed guide wording. Signed-off-by: AWSHurneyt <[email protected]> * Reverted bwc workflow JDK. Signed-off-by: AWSHurneyt <[email protected]>

* Added support for JDK 8 and 14. (#335) * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <[email protected]> * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <[email protected]> * Added 1.3 release notes. (#336) * Added 1.3 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added 1.3 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Add backport and auto delete workflow (#339) Signed-off-by: Annie Lee <[email protected]> * Implemented support for ClusterMetrics monitors (#221) (#342) * Implemented support for LocalUriInput monitors. Signed-off-by: AWSHurneyt <[email protected]> * Refactored feature naming convention from LocalUriInput to ClusterMetricsInput. Added Cluster Metrics as a new monitor type to align with frontend experience. Signed-off-by: AWSHurneyt <[email protected]> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <[email protected]> * Implemented randomClusterMetricsMonitor test helper, and refactored tests accordingly. Signed-off-by: AWSHurneyt <[email protected]> * Renamed some assets to align with the new name for this feature. Signed-off-by: AWSHurneyt <[email protected]> * Refactored cluster metrics feature to remove support for Cat repositories API. Signed-off-by: AWSHurneyt <[email protected]> * Refactored supported JSON payload to return all response fields. Signed-off-by: AWSHurneyt <[email protected]> * Refactored nodes stats request object to return all metrics. Signed-off-by: AWSHurneyt <[email protected]> * Refactored nodes stats request object to return all metrics. Signed-off-by: AWSHurneyt <[email protected]> * Removing unused connectionTimeout and socketTimeout params. Signed-off-by: AWSHurneyt <[email protected]> * Added cluster metrics monitor to release notes. (#343) * Added 1.3 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added 1.3 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added cluster metrics monitor to release notes. Signed-off-by: AWSHurneyt <[email protected]> * Updated DEVELOPER_GUIDE.md and workflows to reference changes to the supported JDKs. (#338) * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <[email protected]> * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <[email protected]> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <[email protected]> * Added additional release note. Signed-off-by: AWSHurneyt <[email protected]> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <[email protected]> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <[email protected]> * Updated workflows to build using JDK 11. Signed-off-by: AWSHurneyt <[email protected]> * Removing redundant JDK setup step. Signed-off-by: AWSHurneyt <[email protected]> * Fixed guide wording. Signed-off-by: AWSHurneyt <[email protected]> * Fixed guide wording. Signed-off-by: AWSHurneyt <[email protected]> * Reverted bwc workflow JDK. Signed-off-by: AWSHurneyt <[email protected]> Co-authored-by: Annie Lee <[email protected]>

…roject#345) * Added support for JDK 8 and 14. (opensearch-project#335) * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <[email protected]> * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <[email protected]> * Added 1.3 release notes. (opensearch-project#336) * Added 1.3 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added 1.3 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Add backport and auto delete workflow (opensearch-project#339) Signed-off-by: Annie Lee <[email protected]> * Implemented support for ClusterMetrics monitors (opensearch-project#221) (opensearch-project#342) * Implemented support for LocalUriInput monitors. Signed-off-by: AWSHurneyt <[email protected]> * Refactored feature naming convention from LocalUriInput to ClusterMetricsInput. Added Cluster Metrics as a new monitor type to align with frontend experience. Signed-off-by: AWSHurneyt <[email protected]> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <[email protected]> * Implemented randomClusterMetricsMonitor test helper, and refactored tests accordingly. Signed-off-by: AWSHurneyt <[email protected]> * Renamed some assets to align with the new name for this feature. Signed-off-by: AWSHurneyt <[email protected]> * Refactored cluster metrics feature to remove support for Cat repositories API. Signed-off-by: AWSHurneyt <[email protected]> * Refactored supported JSON payload to return all response fields. Signed-off-by: AWSHurneyt <[email protected]> * Refactored nodes stats request object to return all metrics. Signed-off-by: AWSHurneyt <[email protected]> * Refactored nodes stats request object to return all metrics. Signed-off-by: AWSHurneyt <[email protected]> * Removing unused connectionTimeout and socketTimeout params. Signed-off-by: AWSHurneyt <[email protected]> * Added cluster metrics monitor to release notes. (opensearch-project#343) * Added 1.3 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added 1.3 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added cluster metrics monitor to release notes. Signed-off-by: AWSHurneyt <[email protected]> * Updated DEVELOPER_GUIDE.md and workflows to reference changes to the supported JDKs. (opensearch-project#338) * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <[email protected]> * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <[email protected]> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <[email protected]> * Added additional release note. Signed-off-by: AWSHurneyt <[email protected]> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <[email protected]> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <[email protected]> * Updated workflows to build using JDK 11. Signed-off-by: AWSHurneyt <[email protected]> * Removing redundant JDK setup step. Signed-off-by: AWSHurneyt <[email protected]> * Fixed guide wording. Signed-off-by: AWSHurneyt <[email protected]> * Fixed guide wording. Signed-off-by: AWSHurneyt <[email protected]> * Reverted bwc workflow JDK. Signed-off-by: AWSHurneyt <[email protected]> Co-authored-by: Annie Lee <[email protected]>

* Add 1.2.4.0 release notes (#282) * Add 1.2.4.0 release notes Signed-off-by: Ashish Agrawal <[email protected]> * Commented out flaky test in favor of known issue to unblock build (#331) (#332) (#333) * Commented out flaky test in favor of known issue #300 to unblock build process. Signed-off-by: Saurabh Singh <[email protected]> * Commenting out another test Signed-off-by: Aditya Jindal <[email protected]> Co-authored-by: Saurabh Singh <[email protected]> Co-authored-by: Aditya Jindal <[email protected]> Co-authored-by: Saurabh Singh <[email protected]> Co-authored-by: Aditya Jindal <[email protected]> Co-authored-by: Saurabh Singh <[email protected]> Co-authored-by: Aditya Jindal <[email protected]> * Cherry-picking commits for 1.3 release from main to 1.x (#345) * Added support for JDK 8 and 14. (#335) * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <[email protected]> * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <[email protected]> * Added 1.3 release notes. (#336) * Added 1.3 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added 1.3 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Add backport and auto delete workflow (#339) Signed-off-by: Annie Lee <[email protected]> * Implemented support for ClusterMetrics monitors (#221) (#342) * Implemented support for LocalUriInput monitors. Signed-off-by: AWSHurneyt <[email protected]> * Refactored feature naming convention from LocalUriInput to ClusterMetricsInput. Added Cluster Metrics as a new monitor type to align with frontend experience. Signed-off-by: AWSHurneyt <[email protected]> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <[email protected]> * Implemented randomClusterMetricsMonitor test helper, and refactored tests accordingly. Signed-off-by: AWSHurneyt <[email protected]> * Renamed some assets to align with the new name for this feature. Signed-off-by: AWSHurneyt <[email protected]> * Refactored cluster metrics feature to remove support for Cat repositories API. Signed-off-by: AWSHurneyt <[email protected]> * Refactored supported JSON payload to return all response fields. Signed-off-by: AWSHurneyt <[email protected]> * Refactored nodes stats request object to return all metrics. Signed-off-by: AWSHurneyt <[email protected]> * Refactored nodes stats request object to return all metrics. Signed-off-by: AWSHurneyt <[email protected]> * Removing unused connectionTimeout and socketTimeout params. Signed-off-by: AWSHurneyt <[email protected]> * Added cluster metrics monitor to release notes. (#343) * Added 1.3 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added 1.3 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added cluster metrics monitor to release notes. Signed-off-by: AWSHurneyt <[email protected]> * Updated DEVELOPER_GUIDE.md and workflows to reference changes to the supported JDKs. (#338) * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <[email protected]> * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <[email protected]> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <[email protected]> * Added additional release note. Signed-off-by: AWSHurneyt <[email protected]> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <[email protected]> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <[email protected]> * Updated workflows to build using JDK 11. Signed-off-by: AWSHurneyt <[email protected]> * Removing redundant JDK setup step. Signed-off-by: AWSHurneyt <[email protected]> * Fixed guide wording. Signed-off-by: AWSHurneyt <[email protected]> * Fixed guide wording. Signed-off-by: AWSHurneyt <[email protected]> * Reverted bwc workflow JDK. Signed-off-by: AWSHurneyt <[email protected]> Co-authored-by: Annie Lee <[email protected]> Co-authored-by: Ashish Agrawal <[email protected]> Co-authored-by: Saurabh Singh <[email protected]> Co-authored-by: Saurabh Singh <[email protected]> Co-authored-by: Aditya Jindal <[email protected]> Co-authored-by: Annie Lee <[email protected]>

…roject#345) * Added support for JDK 8 and 14. (opensearch-project#335) * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <[email protected]> * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <[email protected]> * Added 1.3 release notes. (opensearch-project#336) * Added 1.3 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added 1.3 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Add backport and auto delete workflow (opensearch-project#339) Signed-off-by: Annie Lee <[email protected]> * Implemented support for ClusterMetrics monitors (opensearch-project#221) (opensearch-project#342) * Implemented support for LocalUriInput monitors. Signed-off-by: AWSHurneyt <[email protected]> * Refactored feature naming convention from LocalUriInput to ClusterMetricsInput. Added Cluster Metrics as a new monitor type to align with frontend experience. Signed-off-by: AWSHurneyt <[email protected]> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <[email protected]> * Implemented randomClusterMetricsMonitor test helper, and refactored tests accordingly. Signed-off-by: AWSHurneyt <[email protected]> * Renamed some assets to align with the new name for this feature. Signed-off-by: AWSHurneyt <[email protected]> * Refactored cluster metrics feature to remove support for Cat repositories API. Signed-off-by: AWSHurneyt <[email protected]> * Refactored supported JSON payload to return all response fields. Signed-off-by: AWSHurneyt <[email protected]> * Refactored nodes stats request object to return all metrics. Signed-off-by: AWSHurneyt <[email protected]> * Refactored nodes stats request object to return all metrics. Signed-off-by: AWSHurneyt <[email protected]> * Removing unused connectionTimeout and socketTimeout params. Signed-off-by: AWSHurneyt <[email protected]> * Added cluster metrics monitor to release notes. (opensearch-project#343) * Added 1.3 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added 1.3 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added cluster metrics monitor to release notes. Signed-off-by: AWSHurneyt <[email protected]> * Updated DEVELOPER_GUIDE.md and workflows to reference changes to the supported JDKs. (opensearch-project#338) * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <[email protected]> * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <[email protected]> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <[email protected]> * Added additional release note. Signed-off-by: AWSHurneyt <[email protected]> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <[email protected]> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <[email protected]> * Updated workflows to build using JDK 11. Signed-off-by: AWSHurneyt <[email protected]> * Removing redundant JDK setup step. Signed-off-by: AWSHurneyt <[email protected]> * Fixed guide wording. Signed-off-by: AWSHurneyt <[email protected]> * Fixed guide wording. Signed-off-by: AWSHurneyt <[email protected]> * Reverted bwc workflow JDK. Signed-off-by: AWSHurneyt <[email protected]> Co-authored-by: Annie Lee <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>

AWSHurneyt added 5 commits March 10, 2022 10:12

Added support for JDK 8 and 14.

854fdae

Signed-off-by: AWSHurneyt <[email protected]>

Added support for JDK 8 and 14.

3782791

Signed-off-by: AWSHurneyt <[email protected]>

Merge branch 'opensearch-project:main' into jdkversions

c29e8f3

Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs.

e6572d5

Signed-off-by: AWSHurneyt <[email protected]>

Added additional release note.

2ecefe2

Signed-off-by: AWSHurneyt <[email protected]>

AWSHurneyt added the v1.3.0 label Mar 10, 2022

Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs.

21b932d

Signed-off-by: AWSHurneyt <[email protected]>

AWSHurneyt marked this pull request as ready for review March 10, 2022 19:47

AWSHurneyt requested review from a team, adityaj1107, bowenlan-amzn, getsaurabh02, annie3431 and qreshi March 10, 2022 19:47

AWSHurneyt added 3 commits March 10, 2022 13:54

Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs.

b400d10

Signed-off-by: AWSHurneyt <[email protected]>

Merge branch 'opensearch-project:main' into jdkversions

a3cbff6

Updated workflows to build using JDK 11.

6e2ec16

Signed-off-by: AWSHurneyt <[email protected]>

AWSHurneyt changed the title ~~Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs.~~ Updated DEVELOPER_GUIDE.md and workflows to reference changes to the supported JDKs. Mar 10, 2022

downsrob reviewed Mar 10, 2022

View reviewed changes

DEVELOPER_GUIDE.md Outdated Show resolved Hide resolved

Removing redundant JDK setup step.

b07aca4

Signed-off-by: AWSHurneyt <[email protected]>

downsrob reviewed Mar 10, 2022

View reviewed changes

DEVELOPER_GUIDE.md Outdated Show resolved Hide resolved

downsrob reviewed Mar 10, 2022

View reviewed changes

DEVELOPER_GUIDE.md Outdated Show resolved Hide resolved

AWSHurneyt added 2 commits March 10, 2022 15:51

Fixed guide wording.

ebd500d

Signed-off-by: AWSHurneyt <[email protected]>

Fixed guide wording.

c4788a9

Signed-off-by: AWSHurneyt <[email protected]>

praveensameneni approved these changes Mar 11, 2022

View reviewed changes

Reverted bwc workflow JDK.

8a3d494

Signed-off-by: AWSHurneyt <[email protected]>

downsrob approved these changes Mar 11, 2022

View reviewed changes

annie3431 approved these changes Mar 11, 2022

View reviewed changes

AWSHurneyt merged commit 9487c00 into opensearch-project:main Mar 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated DEVELOPER_GUIDE.md and workflows to reference changes to the supported JDKs. #338

Updated DEVELOPER_GUIDE.md and workflows to reference changes to the supported JDKs. #338

AWSHurneyt commented Mar 10, 2022 •

edited

Loading

codecov-commenter commented Mar 10, 2022 •

edited

Loading

AWSHurneyt commented Mar 10, 2022

Updated DEVELOPER_GUIDE.md and workflows to reference changes to the supported JDKs. #338

Updated DEVELOPER_GUIDE.md and workflows to reference changes to the supported JDKs. #338

Conversation

AWSHurneyt commented Mar 10, 2022 • edited Loading

codecov-commenter commented Mar 10, 2022 • edited Loading

Codecov Report

AWSHurneyt commented Mar 10, 2022

AWSHurneyt commented Mar 10, 2022 •

edited

Loading

codecov-commenter commented Mar 10, 2022 •

edited

Loading