Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commented out flaky test in favor of known issue to unblock build #331

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

getsaurabh02
Copy link
Member

Issue #, if available:
Commented out the flaky tests due to a known issue #300 to unblock build jobs.

Tests with failures:
[317](https://github.com/opensearch-project/alerting/runs/5472237725?check_suite_focus=true#step:8:317)
 - org.opensearch.alerting.resthandler.SecureMonitorRestApiIT.test query monitors with enable filter by
[318](https://github.com/opensearch-project/alerting/runs/5472237725?check_suite_focus=true#step:8:318)
 - org.opensearch.alerting.resthandler.SecureMonitorRestApiIT.test query all alerts in all states with disabled filter by
[319](https://github.com/opensearch-project/alerting/runs/5472237725?check_suite_focus=true#step:8:319)
 - org.opensearch.alerting.resthandler.SecureMonitorRestApiIT.test query all alerts in all states with filter by
[320](https://github.com/opensearch-project/alerting/runs/5472237725?check_suite_focus=true#step:8:320)
 - org.opensearch.alerting.resthandler.SecureMonitorRestApiIT.test delete monitor with an user without delete monitor access
[321](https://github.com/opensearch-project/alerting/runs/5472237725?check_suite_focus=true#step:8:321)
 - org.opensearch.alerting.MonitorRunnerIT.test execute monitor with custom webhook destination
 

Description of changes:

CheckList:
[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@getsaurabh02 getsaurabh02 requested a review from a team March 10, 2022 03:33
… to unblock build process.

Signed-off-by: Saurabh Singh <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #331 (917e544) into main (5f18a5c) will decrease coverage by 0.14%.
The diff coverage is n/a.

❗ Current head 917e544 differs from pull request most recent head 8d01bf5. Consider uploading reports for the commit 8d01bf5 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #331      +/-   ##
============================================
- Coverage     78.59%   78.45%   -0.15%     
+ Complexity      218      214       -4     
============================================
  Files           173      173              
  Lines          6975     6975              
  Branches        916      916              
============================================
- Hits           5482     5472      -10     
- Misses         1005     1013       +8     
- Partials        488      490       +2     
Impacted Files Coverage Δ
...ation/factory/CustomWebhookDestinationFactory.java 75.00% <0.00%> (-25.00%) ⬇️
...ing/destination/client/DestinationEmailClient.java 72.50% <0.00%> (-5.00%) ⬇️
...ing/model/destination/DestinationContextFactory.kt 66.66% <0.00%> (-3.71%) ⬇️
...ting/destination/message/CustomWebhookMessage.java 80.00% <0.00%> (-1.54%) ⬇️
...ting/destination/client/DestinationHttpClient.java 86.36% <0.00%> (-1.52%) ⬇️
...ain/kotlin/org/opensearch/alerting/AlertService.kt 78.04% <0.00%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f18a5c...8d01bf5. Read the comment docs.

@getsaurabh02 getsaurabh02 force-pushed the main branch 2 times, most recently from 917e544 to 2e5b529 Compare March 10, 2022 07:03
Signed-off-by: Aditya Jindal <[email protected]>
@getsaurabh02 getsaurabh02 merged commit a5c5cb3 into opensearch-project:main Mar 10, 2022
getsaurabh02 added a commit to getsaurabh02/alerting that referenced this pull request Mar 10, 2022
…ensearch-project#331)

* Commented out flaky test in favor of known issue opensearch-project#300 to unblock build process.

Signed-off-by: Saurabh Singh <[email protected]>

* Commenting out another test

Signed-off-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>
adityaj1107 added a commit that referenced this pull request Mar 10, 2022
…) (#332)

* Commented out flaky test in favor of known issue #300 to unblock build process.

Signed-off-by: Saurabh Singh <[email protected]>

* Commenting out another test

Signed-off-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>
getsaurabh02 added a commit to getsaurabh02/alerting that referenced this pull request Mar 10, 2022
…ensearch-project#331) (opensearch-project#332)

* Commented out flaky test in favor of known issue opensearch-project#300 to unblock build process.

Signed-off-by: Saurabh Singh <[email protected]>

* Commenting out another test

Signed-off-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>
getsaurabh02 added a commit that referenced this pull request Mar 10, 2022
…) (#332) (#333)

* Commented out flaky test in favor of known issue #300 to unblock build process.

Signed-off-by: Saurabh Singh <[email protected]>

* Commenting out another test

Signed-off-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/OpenSearch-Alerting that referenced this pull request Mar 11, 2022
…ensearch-project#331) (opensearch-project#332) (opensearch-project#333)

* Commented out flaky test in favor of known issue opensearch-project#300 to unblock build process.

Signed-off-by: Saurabh Singh <[email protected]>

* Commenting out another test

Signed-off-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>
AWSHurneyt added a commit that referenced this pull request Mar 11, 2022
* Add 1.2.4.0 release notes (#282)

* Add 1.2.4.0 release notes

Signed-off-by: Ashish Agrawal <[email protected]>

* Commented out flaky test in favor of known issue to unblock build (#331) (#332) (#333)

* Commented out flaky test in favor of known issue #300 to unblock build process.

Signed-off-by: Saurabh Singh <[email protected]>

* Commenting out another test

Signed-off-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>

* Cherry-picking commits for 1.3 release from main to 1.x (#345)

* Added support for JDK 8 and 14. (#335)

* Added support for JDK 8 and 14.

Signed-off-by: AWSHurneyt <[email protected]>

* Added support for JDK 8 and 14.

Signed-off-by: AWSHurneyt <[email protected]>

* Added 1.3 release notes. (#336)

* Added 1.3 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Added 1.3 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Add backport and auto delete workflow (#339)

Signed-off-by: Annie Lee <[email protected]>

* Implemented support for ClusterMetrics monitors (#221) (#342)

* Implemented support for LocalUriInput monitors.

Signed-off-by: AWSHurneyt <[email protected]>

* Refactored feature naming convention from LocalUriInput to ClusterMetricsInput. Added Cluster Metrics as a new monitor type to align with frontend experience.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed ktlint errors.

Signed-off-by: AWSHurneyt <[email protected]>

* Implemented randomClusterMetricsMonitor test helper, and refactored tests accordingly.

Signed-off-by: AWSHurneyt <[email protected]>

* Renamed some assets to align with the new name for this feature.

Signed-off-by: AWSHurneyt <[email protected]>

* Refactored cluster metrics feature to remove support for Cat repositories API.

Signed-off-by: AWSHurneyt <[email protected]>

* Refactored supported JSON payload to return all response fields.

Signed-off-by: AWSHurneyt <[email protected]>

* Refactored nodes stats request object to return all metrics.

Signed-off-by: AWSHurneyt <[email protected]>

* Refactored nodes stats request object to return all metrics.

Signed-off-by: AWSHurneyt <[email protected]>

* Removing unused connectionTimeout and socketTimeout params.

Signed-off-by: AWSHurneyt <[email protected]>

* Added cluster metrics monitor to release notes. (#343)

* Added 1.3 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Added 1.3 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Added cluster metrics monitor to release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated DEVELOPER_GUIDE.md and workflows to reference changes to the supported JDKs. (#338)

* Added support for JDK 8 and 14.

Signed-off-by: AWSHurneyt <[email protected]>

* Added support for JDK 8 and 14.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs.

Signed-off-by: AWSHurneyt <[email protected]>

* Added additional release note.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated workflows to build using JDK 11.

Signed-off-by: AWSHurneyt <[email protected]>

* Removing redundant JDK setup step.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed guide wording.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed guide wording.

Signed-off-by: AWSHurneyt <[email protected]>

* Reverted bwc workflow JDK.

Signed-off-by: AWSHurneyt <[email protected]>

Co-authored-by: Annie Lee <[email protected]>

Co-authored-by: Ashish Agrawal <[email protected]>
Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>
Co-authored-by: Annie Lee <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/OpenSearch-Alerting that referenced this pull request Mar 30, 2022
…ensearch-project#331) (opensearch-project#332)

* Commented out flaky test in favor of known issue opensearch-project#300 to unblock build process.

Signed-off-by: Saurabh Singh <[email protected]>

* Commenting out another test

Signed-off-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: Aditya Jindal <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants