Adding ITs to check for Default Role Permissions #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityaj1107
requested review from
a team,
lezzago,
rishabhmaurya and
AWSHurneyt
|
ITs tests passing locally: - https://github.com/aditjind/alerting/pull/12 |
Codecov Report
@@ Coverage Diff @@
## main #299 +/- ##
============================================
- Coverage 78.52% 78.50% -0.02%
+ Complexity 218 217 -1
============================================
Files 173 173
Lines 6975 6975
Branches 916 916
============================================
- Hits 5477 5476 -1
- Misses 1006 1007 +1
Partials 492 492
Continue to review full report at Codecov.
|
AWSHurneyt
approved these changes
Feb 3, 2022
lezzago
reviewed
Feb 4, 2022
alerting/src/test/kotlin/org/opensearch/alerting/AlertingRestTestCase.kt
Outdated
Show resolved
Hide resolved
alerting/src/test/kotlin/org/opensearch/alerting/TestHelpers.kt
Outdated
Show resolved
Hide resolved
alerting/src/test/kotlin/org/opensearch/alerting/resthandler/SecureMonitorRestApiIT.kt
Outdated
Show resolved
Hide resolved
alerting/src/test/kotlin/org/opensearch/alerting/resthandler/SecureMonitorRestApiIT.kt
Outdated
Show resolved
Hide resolved
lezzago
reviewed
Feb 4, 2022
alerting/src/test/kotlin/org/opensearch/alerting/resthandler/SecureMonitorRestApiIT.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Aditya Jindal <[email protected]>
Signed-off-by: Aditya Jindal <[email protected]>
Signed-off-by: Aditya Jindal <[email protected]>
Signed-off-by: Aditya Jindal <[email protected]>
Signed-off-by: Aditya Jindal <[email protected]>
lezzago
approved these changes
Feb 4, 2022
qreshi
pushed a commit
to qreshi/opensearch-alerting
that referenced
this pull request
Feb 14, 2022
) * Adding ITs to check for Default Role Permissions Signed-off-by: Aditya Jindal <[email protected]>
qreshi
pushed a commit
to qreshi/opensearch-alerting
that referenced
this pull request
Feb 15, 2022
) * Adding ITs to check for Default Role Permissions Signed-off-by: Aditya Jindal <[email protected]>
qreshi
pushed a commit
that referenced
this pull request
Feb 21, 2022
* Adding ITs to check for Default Role Permissions Signed-off-by: Aditya Jindal <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/OpenSearch-Alerting
that referenced
this pull request
Mar 30, 2022
) * Adding ITs to check for Default Role Permissions Signed-off-by: Aditya Jindal <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aditya Jindal [email protected]
Issue #, if available: #219
Description of changes:
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.