[senseBox] Forgot to add binding to feature.xml #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hakan Tandogan <[email protected]>
|
Weird... Didn't you miss it in the distro then? Thanks for adding it now! |
|
Hmm, guys, I think it's worse 👎 It's not in the pom.xml either. |
|
My excuse is that I was on the IoT tech days while reviewing ;-) |
On my system, I was always using the self-compiled one... Actually, it's the first time I am checking the full distribution 😊
Really? I'll check immediately and create a new PR... More things to check before I start a PR, I guess... |
|
Here it is: https://github.com/openhab/openhab2-addons/pull/2372 And this time, I ran a full build on my machine to make sure the binding is being picked up for compilation 😊 |
holmes
added a commit
to holmes/openhab2-addons
that referenced
this pull request
Jun 16, 2017
* master: [senseBox] Forgot to add binding to feature.xml (openhab#2371) [Kodi] Fix audio sink (openhab#2301) (openhab#2303) Initial contribution of a Niko Home Control binding. (openhab#1589) [keba] fixed typo (openhab#2370) Removed utilisation of org.apache.http.client (openhab#2369) [RFXCOM] Make LWRF mood buttons work (openhab#2366) [senseBox] Switch caching to ESH ExpiringCacheMap (openhab#2361) Fixed problems found by AuthorTagCheck in the cometvisu bundle (openhab#2364) Added author tag where missing. (openhab#2351) [RFXCOM] Fix chill temperature (openhab#2362) initial contribution Windcentrale binding (openhab#1535) Tesla : reset the Even Stream connection to the Tesla Back-end if the event time stamps differ too much from the current system time (openhab#2358) Homematic: Some updates (openhab#2346) [RFXCOM] Support all data from wind sensors (openhab#2329) Gardena: Optimized refresh after command (openhab#2353) Fix some javadocs. (openhab#2349) Some small non-standard copyright banners which we missed while reviewing (openhab#2347)
falkena
pushed a commit
to falkena/openhab-addons
that referenced
this pull request
Jun 29, 2017
Signed-off-by: Hakan Tandogan <[email protected]>
qvistgaard
pushed a commit
to qvistgaard/openhab2-addons
that referenced
this pull request
Jun 30, 2017
Signed-off-by: Hakan Tandogan <[email protected]>
jsjames
pushed a commit
to jsjames/openhab-addons
that referenced
this pull request
Jul 1, 2017
Signed-off-by: Hakan Tandogan <[email protected]>
reyem
pushed a commit
to reyem/openhab2-addons
that referenced
this pull request
Jul 1, 2017
Signed-off-by: Hakan Tandogan <[email protected]>
Markinus
pushed a commit
to Markinus/openhab2-addons
that referenced
this pull request
Jul 2, 2017
Signed-off-by: Hakan Tandogan <[email protected]>
ppieczul
pushed a commit
to ppieczul/openhab2-addons
that referenced
this pull request
Jul 2, 2017
Signed-off-by: Hakan Tandogan <[email protected]>
aogorek
pushed a commit
to aogorek/openhab2-addons
that referenced
this pull request
Jul 5, 2017
Signed-off-by: Hakan Tandogan <[email protected]>
Markinus
pushed a commit
to Markinus/openhab2-addons
that referenced
this pull request
Sep 8, 2017
Signed-off-by: Hakan Tandogan <[email protected]>
hillmanr
pushed a commit
to hillmanr/openhab2-addons-pollytts
that referenced
this pull request
Dec 6, 2017
Signed-off-by: Hakan Tandogan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow, the commit adding this binding to feature.xml must have got lost before starting the pull requests 😊