Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added author tag where missing. #2351

Merged
merged 1 commit into from
Jun 13, 2017
Merged

Added author tag where missing. #2351

merged 1 commit into from
Jun 13, 2017

Conversation

svilenvul
Copy link

See openhab/static-code-analysis#52

Signed-off-by: Svilen Valkanov [email protected]

@martinvw
Copy link
Member

martinvw commented Jun 9, 2017

There are quite some new lines surrounding the author and sometimes you added " - Initial contribution" and other times not, is there a reason for that?

@svilenvul
Copy link
Author

There are quite some new lines surrounding the author ...

They were automatically added by Eclipse.

... and sometimes you added " - Initial contribution"

I have added it in cases, where the file was edited after the initial commit (many authors are present).

What would you recommend? Remove the lines and be consistent with adding "Initial contribution"?

@martinvw
Copy link
Member

martinvw commented Jun 9, 2017

I'm surprised by the newlines after the author tag, Eclipse has half of an opinion about this, when creating a new empty docblock it adds them but it does not add or remove them to existing ones. Since we stated that every class should contain a docblock stating its purpose a newline on top makes sense, because something is missing. One on the bottom feels strange to me.

Let's make it an "Initial contribution" everywhere

@svilenvul svilenvul force-pushed the add-missing-author-tags branch from 7b5e351 to ae030b6 Compare June 9, 2017 15:13
kaikreuzer
kaikreuzer reviewed Jun 9, 2017
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up :-)

...ava/org/openhab/io/homekit/internal/accessories/AbstractTemperatureHomekitAccessoryImpl.java Outdated
/**
*
* @author Andy Lintner - Initial contribution
* @param <T>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err - either add some description of remove that line

...ab.binding.milight/src/main/java/org/openhab/binding/milight/internal/MilightThingState.java Outdated
@@ -11,6 +11,7 @@
/**
* Contains a led bulb state including the HSB value, white color temperature and animation values.
*
* @author David Graeff <[email protected]> - Initial contribution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could remove his e-mail here as we do not do this (even if he added it on other classes)

...ab.binding.milight/src/main/java/org/openhab/binding/milight/internal/MilightThingState.java Outdated
@@ -11,6 +11,7 @@
/**
* Contains a led bulb state including the HSB value, white color temperature and animation values.
*
* @author David Graeff <[email protected]> - Initial contribution
* @since 2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the since tag at the same time?

...b.binding.milight/src/main/java/org/openhab/binding/milight/internal/protocol/QueueItem.java Outdated
@@ -8,6 +8,10 @@
*/
package org.openhab.binding.milight.internal.protocol;

/**
*
* @author David Graeff <[email protected]> - Initial contribution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove e-mail

@svilenvul svilenvul force-pushed the add-missing-author-tags branch from ae030b6 to 54dddd9 Compare June 12, 2017 06:28
@martinvw
Copy link
Member

@kaikreuzer should be fixed

kaikreuzer
kaikreuzer approved these changes Jun 13, 2017
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@kaikreuzer kaikreuzer merged commit fc2b965 into openhab:master Jun 13, 2017
holmes added a commit to holmes/openhab2-addons that referenced this pull request Jun 16, 2017
@holmes
Merge branch 'master' into holmes/update-status
46ec43c 
* master:
  [senseBox] Forgot to add binding to feature.xml (openhab#2371)
  [Kodi] Fix audio sink (openhab#2301) (openhab#2303)
  Initial contribution of a Niko Home Control binding. (openhab#1589)
  [keba] fixed typo (openhab#2370)
  Removed utilisation of org.apache.http.client (openhab#2369)
  [RFXCOM] Make LWRF mood buttons work (openhab#2366)
  [senseBox] Switch caching to ESH ExpiringCacheMap (openhab#2361)
  Fixed problems found by AuthorTagCheck in the cometvisu bundle (openhab#2364)
  Added author tag where missing. (openhab#2351)
  [RFXCOM] Fix chill temperature (openhab#2362)
  initial contribution Windcentrale binding (openhab#1535)
  Tesla : reset the Even Stream connection to the Tesla Back-end if the event time stamps differ too much from the current system time (openhab#2358)
  Homematic: Some updates (openhab#2346)
  [RFXCOM] Support all data from wind sensors (openhab#2329)
  Gardena: Optimized refresh after command (openhab#2353)
  Fix some javadocs. (openhab#2349)
  Some small non-standard copyright banners which we missed while reviewing (openhab#2347)
@kaikreuzer kaikreuzer modified the milestone: 2.1 Jun 23, 2017
falkena pushed a commit to falkena/openhab-addons that referenced this pull request Jun 29, 2017
Added author tag where missing. (openhab#2351)
f84c402 
See openhab/static-code-analysis#52

Signed-off-by: Svilen Valkanov <[email protected]>
qvistgaard pushed a commit to qvistgaard/openhab2-addons that referenced this pull request Jun 30, 2017
@qvistgaard
Added author tag where missing. (openhab#2351)
3025c87 
See openhab/static-code-analysis#52

Signed-off-by: Svilen Valkanov <[email protected]>
jsjames pushed a commit to jsjames/openhab-addons that referenced this pull request Jul 1, 2017
@jsjames
Added author tag where missing. (openhab#2351)
40f460d 
See openhab/static-code-analysis#52

Signed-off-by: Svilen Valkanov <[email protected]>
reyem pushed a commit to reyem/openhab2-addons that referenced this pull request Jul 1, 2017
@reyem
Added author tag where missing. (openhab#2351)
29a2b93 
See openhab/static-code-analysis#52

Signed-off-by: Svilen Valkanov <[email protected]>
Markinus pushed a commit to Markinus/openhab2-addons that referenced this pull request Jul 2, 2017
@Markinus
Added author tag where missing. (openhab#2351)
2c4890a 
See openhab/static-code-analysis#52

Signed-off-by: Svilen Valkanov <[email protected]>
ppieczul pushed a commit to ppieczul/openhab2-addons that referenced this pull request Jul 2, 2017
@ppieczul
Added author tag where missing. (openhab#2351)
3800748 
See openhab/static-code-analysis#52

Signed-off-by: Svilen Valkanov <[email protected]>
reyem pushed a commit to reyem/openhab2-addons that referenced this pull request Jul 3, 2017
@reyem
Added author tag where missing. (openhab#2351)
b6c0988 
See openhab/static-code-analysis#52

Signed-off-by: Svilen Valkanov <[email protected]>
aogorek pushed a commit to aogorek/openhab2-addons that referenced this pull request Jul 5, 2017
Added author tag where missing. (openhab#2351)
83ce9c5 
See openhab/static-code-analysis#52

Signed-off-by: Svilen Valkanov <[email protected]>
aogorek pushed a commit to aogorek/openhab2-addons that referenced this pull request Jul 5, 2017
Added author tag where missing. (openhab#2351)
9cf445e 
See openhab/static-code-analysis#52

Signed-off-by: Svilen Valkanov <[email protected]>
Markinus pushed a commit to Markinus/openhab2-addons that referenced this pull request Sep 8, 2017
@Markinus
Added author tag where missing. (openhab#2351)
ea9ae54 
See openhab/static-code-analysis#52

Signed-off-by: Svilen Valkanov <[email protected]>
hillmanr pushed a commit to hillmanr/openhab2-addons-pollytts that referenced this pull request Dec 6, 2017
Added author tag where missing. (openhab#2351)
e7bb726 
See openhab/static-code-analysis#52

Signed-off-by: Svilen Valkanov <[email protected]>
aogorek pushed a commit to aogorek/openhab2-addons that referenced this pull request Dec 30, 2017
Added author tag where missing. (openhab#2351)
ecdef6f 
See openhab/static-code-analysis#52

Signed-off-by: Svilen Valkanov <[email protected]>
Flole998 pushed a commit to Flole998/openhab-addons that referenced this pull request Dec 30, 2021
@cweitkamp
[profiles] Added "timestamp-offset" Profile (openhab#2351)
ba53e8a 
* Added timestamp-offset Profile
* Fix RAWBUTTON_TOGGLE_ROLLERSHUTTER Profile

Signed-off-by: Christoph Weitkamp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@svilenvul @martinvw @kaikreuzer